build: add support for NetBSD in depends #23955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 3, 2022
d1ea46e to
65ae79c
Compare
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 20, 2022
…10 build 6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake) ce6dd2f zeromq 4.3.4 (fanquake) Pull request description: This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10). ACKs for top commit: hebasto: ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
65ae79c to
63c1706
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 20, 2022
…10 build 6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake) ce6dd2f zeromq 4.3.4 (fanquake) Pull request description: This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10). ACKs for top commit: hebasto: ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
|
If some NetBSD bitcoiner is looking at this, would be cool to help wih review / test of this - JoinMarket-Org/joinmarket-clientserver#1066. None of JM developers are using NetBSD, so we can't test this ourselves. |
63c1706 to
d28dbbf
Compare
|
Rebased and added Guix build to PR description. |
d28dbbf to
d25f3d5
Compare
|
Tested d25f3d5 in fresh installation of NetBSD 9.2. Packages that were required to build depends: Building depends: Building Bitcoin Core: Failure with Boost.Process: |
Tested #24254 with this PR, and it fixes this error. |
hebasto
approved these changes
Feb 14, 2022
| x86_64_netbsd_CXX=$(default_host_CXX) -m64 | ||
| endif | ||
|
|
||
| netbsd_cmake_system=NetBSD |
There was a problem hiding this comment.
FWIW, CMake docs say nothing about cross compiling for NetBSD, and about setting of the CMAKE_SYSTEM_NAME macro for such a case.
d25f3d5 to
28efee6
Compare
Guix builds: |
theuni
reviewed
Feb 14, 2022
There was a problem hiding this comment.
I suppose this is just for convenience, and not intended to be supported in any way? If so, Concept ACK
The additions look good to me other than the wonky CXXFLAGS.
My only concern is that since this isn't being tested, what happens if/when builds stop working and nobody notices or bothers to fix. Maybe explicitly describe it as unsupported somewhere? That way at least people would be hesitant to rely on it. Same goes for freebsd, I suppose.
28efee6 to
ea2a120
Compare
Yes. The intention is minimal support, but enough that depends is usable on *BSD platforms. I will be testing builds irregularly, however given that we aren't supporting Qt, and the continued reduction in dependencies, I also don't expect things too break too often. |
ea2a120 to
1f33d92
Compare
theuni
reviewed
Feb 14, 2022
1f33d92 to
bcd36e1
Compare
theuni
approved these changes
Feb 14, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 15, 2022
bcd36e1 build: correct depends FreeBSD C{XX}FLAGS (fanquake) 7b06ffc build: add NetBSD support to depends (fanquake) Pull request description: Similar to bitcoin#23948. Doesn't build the Qt package; I haven't looked at doing that yet, but have an assumption that it's going to fail out of the box similar to the FreeBSD build. Guix Build: ```bash ``` ACKs for top commit: theuni: ACK bcd36e1 Tree-SHA512: 9a0946cefbcb9a92dd730b885463f3213e304c8d4b39fea8d831fc013a73d2ef998ca84e384bf45a01fa1449cf5a35eaffaa5b57a9062c2cdda34312d33ec3fc
This was referenced Mar 21, 2023
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #23948. Doesn't build the Qt package; I haven't looked at doing that yet, but have an assumption that it's going to fail out of the box similar to the FreeBSD build.
Guix Build: