Skip to content

Conversation

musvaage
Copy link
Contributor

yarikoptic added a commit to yarikoptic/codespell that referenced this pull request Dec 14, 2023
Originally detected/fixed in
zenodo/zenodo#2519

Apparently there is 13k hits on github:
https://github.com/search?q=verision&type=code

The other possible close match is derision, which is a
legit word and is used in about of 45k hits on github:
https://github.com/search?q=derision&type=code

'd' is nearby 'v', so even though unlikely, I have decided
that best to have multiple choices here.
@musvaage
Copy link
Contributor Author

@slint

What 's the explanation for the failing check?

In retrospect if any of the description fields modified in #2423 (Closed) should be reverted this can be pursued.

The description fields originated externally to this repository and factually the modifications thereto should be reverted.

@musvaage
Copy link
Contributor Author

it was incorrect to approve that the description fields be modified in #2423 (Closed)

that being said there neither appears to be forthcoming Maintainer response on this pull nor a decision on #2470

@yarikoptic
Copy link

if "maintainer" is to be me -- please let me know what is desired to be done here???

Frankly I am surprised that this PR with such trivial fixes requires some more discussion and was not yet merged.

@musvaage
Copy link
Contributor Author

The Author, Maintainer or Member may identify the relation of the individual to a ticket.

@musvaage
Copy link
Contributor Author

musvaage commented Feb 20, 2024

it was incorrect to approve that the description fields be modified in #2423 (Closed)

Notwithstanding other Maintainer priorities, but I'm reluctant to even open a PR reverting those incorrect changes in #2423.

@yarikoptic
Copy link

must be me but I am not following. Anyways -- apparently I was assigned a reviewer, I approve . CI fails since python 2.7 is no more (so someone should address that separately). Let me know if I could be of any other help.

@slint
Copy link
Member

slint commented Feb 20, 2024

@yarikoptic @musvaage I'm sorry to jump in this late. This repository has been somewhat inactive for the past year or so, because we've moved development over to https://github.com/zenodo/zenodo-rdm/ due to a large upgrade and migration to Zenodo. We plan to transfer the code back to this repository and continue development here, but there's no specific timeline for that.

In the meantime, I will look into how it would be possible to notify/warn that PRs in this repository's current state should be avoided.

Thank you for your contributions, but unfortunately I'll have to close this PR and #2470.

@ppanero
Copy link

ppanero commented Feb 20, 2024

@slint you can use peter-evans/create-or-update-comment@v3 GH action to automatically add comments to PRs

@musvaage
Copy link
Contributor Author

description fields be modified in #2423

Again, so it's not overlooked when development starts up again in this repo, those description fields were from external sources.

reviewer

A reviewer to a GH pull would typically be a repo Collaborator, Maintainer or Member, that is someone with write authority.

DimitriPapadopoulos pushed a commit to yarikoptic/codespell that referenced this pull request Jun 28, 2024
Originally detected/fixed in
zenodo/zenodo#2519

Apparently there is 13k hits on github:
https://github.com/search?q=verision&type=code

The other possible close match is derision, which is a
legit word and is used in about of 45k hits on github:
https://github.com/search?q=derision&type=code

'd' is nearby 'v', so even though unlikely, I have decided
that best to have multiple choices here.
DimitriPapadopoulos pushed a commit to yarikoptic/codespell that referenced this pull request Jun 28, 2024
Originally detected/fixed in
zenodo/zenodo#2519

Apparently there is 13k hits on github:
https://github.com/search?q=verision&type=code

The other possible close match is derision, which is a
legit word and is used in about of 45k hits on github:
https://github.com/search?q=derision&type=code

'd' is nearby 'v', so even though unlikely, I have decided
that best to have multiple choices here.
DimitriPapadopoulos pushed a commit to codespell-project/codespell that referenced this pull request Jun 28, 2024
Originally detected/fixed in
zenodo/zenodo#2519

Apparently there is 13k hits on github:
https://github.com/search?q=verision&type=code

The other possible close match is derision, which is a
legit word and is used in about of 45k hits on github:
https://github.com/search?q=derision&type=code

'd' is nearby 'v', so even though unlikely, I have decided
that best to have multiple choices here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants