Skip to content

Conversation

afuetterer
Copy link

@afuetterer afuetterer commented Sep 22, 2023

Hi, this is my first PR to the project.

Should PRs be pointed at the master branch?

I propose to fix some minor typos (mostly in comments and docstrings).

I was unsure about typos in function, method or class names, e.g.

def test_acess_conditions(desc, expected):

What do you think?

@afuetterer
Copy link
Author

afuetterer commented Sep 24, 2023

Hi, please ignore and close, if this is obsolete because of #2470. But I guess codespell cannot find occurences of "the the" and other grammar related things, that are not dictionary lookups.

@musvaage
Copy link
Contributor

to date neither PR has been commented on by repo Contributors/Maintainers

the predecessor linked to PR (#2470) doesn't implement the following fixes

CONTRIBUTING.rst

- repository). Please include the the word ``SECURITY`` in all-caps in the email
+ repository). Please include the word ``SECURITY`` in all-caps in the email

tests/unit/deposit/test_api_simpleflow.py

-     # Publish new verision
+     # Publish new version

@musvaage
Copy link
Contributor

musvaage commented Nov 23, 2023

unsure about typos in function

@mitsosf

Do you approve fixing that typo?

$ ed -s zenodo/tests/unit/records/test_schemas_legacyjson_load.py <<<'454,458p'
def test_acess_conditions(desc, expected):
    """Test access conditions."""
    assert legacyjson.LegacyMetadataSchemaV1(strict=True).load(
        d(access_right='restricted', access_conditions=desc)
    ).data['access_conditions'] == (expected or desc)
$ 

I'd have approached the subject matter of #2470 differently.

  1. an Issue soliciting Maintainer opinion on adding a workflow to detect new typos if they are introduced
  2. a separate Pull Request fixing the spell-checker identified and other typos

FWIW, the majority of the commits to this repo appear to be 2 to 8 years old.

zenodo/modules/fixtures/data/records.json

I don't see any reason to change the code of @lnielsen to read automated rather than automatized.

Of the root words automate, automatise/automatize, the former since the mid 1950s appears more prevalent.

possibly the author's intention in that file was offers rather than offsers

Seagate Kinetic offsers ethernet enabled disk drives

Incidentally, the motive of @luzpaz in upvoting #2470 escapes me.

The user is a codespell [-project] Collaborator, with no history as a zenodo Contributor.

@musvaage
Copy link
Contributor

musvaage commented Nov 25, 2023

cf: #2423 (Closed)

Modifying description fields in records.json may seem innocuous.

For 10.5281/zenodo.13113 however it is definitely on automatized contraindicated.

Abstract

As C++11 gained almost full support by compilers, it is interesting to see whether we can leverage some of the features to improve performance and reliability of C++ code. This work is focused on four selected problems: time measurement techniques, for-loops efficiency, asychronuous tasks and parallel mode of STL algorithms. For each of them a micro-benchmark is made. All the benchmarks are fully automatized to generate results from running binaries compiled by three compilers: GCC, ICC and Clang with -O2, -O3 and -Ofast options. In order to evaluate vectorization and multithreading, profiling tools such as perf and Intel Vtune are used.

At this point of time my preference would be to close #2470 in favour of this current PR.

@ppanero

I've asked @mitsosf about modifying test_schemas_legacyjson_load.py.

sed -ie "s/acess/access/g" zenodo/tests/unit/records/test_schemas_legacyjson_load.py

Would you furthermore approve these limited modifications to records.json?

sed -ie "s/Kewords/Keywords/g" zenodo/zenodo/modules/fixtures/data/records.json
sed -ie "s/acessible/accessible/g" zenodo/zenodo/modules/fixtures/data/records.json
sed -ie "s/offsers/offers/g" zenodo/zenodo/modules/fixtures/data/records.json
sed -ie "s/tesults/results/g" zenodo/zenodo/modules/fixtures/data/records.json

@afuetterer

Should PRs be pointed at the master branch?

pull 2423 was

If #2470 is closed and responses are forthcoming regarding the .py and .json files are you amenable to implementing those changes (if any) into your PR?


Whether OpenAire would have problems with the .json file changes is unknown.

Kewords

Non-Intrusive User Interaction Monitoring for WinCC OA based Applications
https://explore.openaire.eu/search/publication?pid=10.5281%2Fzenodo.33583

acessible

Zenodo: Preservation Meter
https://explore.openaire.eu/search/publication?pid=10.5281%2Fzenodo.15099

offsers

Evaluating the Performance of Seagate Kinetic Drive Technology and its Integration into the
CERN EOS Storage System

https://explore.openaire.eu/search/publication?pid=10.5281%2Fzenodo.31865

tesults

Evaluation of selected C++11 features with GCC, ICC and Clang
https://explore.openaire.eu/search/publication?pid=10.5281%2Fzenodo.13113

@mitsosf, @ppanero

In retrospect if any of the description fields modified in #2423 (Closed) should be reverted this can be pursued.

@afuetterer
Copy link
Author

Closing this due to inactivity.

Feel free to open a PR yourself @musvaage.

@afuetterer afuetterer closed this Dec 12, 2023
@musvaage musvaage mentioned this pull request Dec 14, 2023
@musvaage
Copy link
Contributor

@afuetterer, @yarikoptic

#2519 fixes 2 typos exposed by @afuetterer but not implemented by @yarikoptic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants