Skip to content

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR adds AllowInert annotation to the data fetching method used from the client. This fixes the case where the items are not rendered when the virtual list is inert.

Fixes #7672

Depends on #7726

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Base automatically changed from test-extract-getting-items-into-helper-class to main August 18, 2025 08:41
@sissbruecker sissbruecker enabled auto-merge (squash) August 19, 2025 08:47
Copy link

@sissbruecker sissbruecker merged commit 6fe05c6 into main Aug 19, 2025
5 checks passed
@sissbruecker sissbruecker deleted the fix-make-fetching-data-possible-when-virtual-list-is-inert branch August 19, 2025 08:57
vaadin-bot pushed a commit that referenced this pull request Aug 19, 2025
* test: extract getting items into helper class

* fix: make fetching data possible when virtual list is inert

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
vaadin-bot pushed a commit that referenced this pull request Aug 19, 2025
* test: extract getting items into helper class

* fix: make fetching data possible when virtual list is inert

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Aug 19, 2025
…7864)

* test: extract getting items into helper class

* fix: make fetching data possible when virtual list is inert

---------

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Aug 19, 2025
…7865)

* test: extract getting items into helper class

* fix: make fetching data possible when virtual list is inert

---------

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual list not rendered if dialog is opened
3 participants