test: extract getting items into helper class #7726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
web-padawan
reviewed
Jul 22, 2025
|
|
||
| public class VirtualListHelpers { | ||
|
|
||
| public static JsonArray getItems(WebDriver driver, WebElement element) { |
There was a problem hiding this comment.
I wonder if this should be part of VirtualListElement instead so that it can be used in custom ITs?
There was a problem hiding this comment.
I considered that too, but couldn't be sure. What do you think? Would it be worth having an explicit API there?
There was a problem hiding this comment.
I think the API could use some more thought, returning a JsonArray is both confusing and inconvenient. Let's keep this internal for now.
sissbruecker
approved these changes
Aug 18, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
added a commit
that referenced
this pull request
Aug 19, 2025
sissbruecker
added a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts the static method
getItemsfor virtual list elements to a helper class.Type of change
Checklist