This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Fix prom_api.reset_metric_retention_period
#180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumerman
reviewed
Apr 11, 2022
jgpruitt
approved these changes
Apr 11, 2022
cevian
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
LGTM not sure why this wasn't caught by the connector's e2e tests. Maybe ping @antekresic who worked on this feature?
It's not covered at all in the connector e2e tests. I'm going to add a test for it before I merge this change. |
a59cca2 to
3b9da52
Compare
1 task
Yes, thanks to the regression test I found another bug/typo. |
JamesGuthrie
added a commit
to timescale/promscale
that referenced
this pull request
Apr 12, 2022
In [1] we fixed some typos in the `reset_metric_retention_period` function which caused the function to break when used with two-step continuous aggregates. This change adds tests cases to exercise `reset_metric_retention_period` with two-step aggregates. [1]: timescale/promscale_extension#180
A couple of typos in this function broke it when used with two-step continuous aggregates. A companion change in the promscale repository adds a test to exercise this code path [1]. [1]: timescale/promscale#1294
3b9da52 to
febca77
Compare
prom_api.reset_metric_retention_period
JamesGuthrie
added a commit
to timescale/promscale
that referenced
this pull request
Apr 13, 2022
In [1] we fixed some typos in the `reset_metric_retention_period` function which caused the function to break when used with two-step continuous aggregates. This change adds tests cases to exercise `reset_metric_retention_period` with two-step aggregates. [1]: timescale/promscale_extension#180
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of typos in this function broke it when used with two-step
continuous aggregates. A companion change in the promscale repository
adds a test to exercise this code path 1.