Add test case for reset_metric_retention_period with two-step agg
#1294
Conversation
207ce85 to
8521477
Compare
8521477 to
3c070a3
Compare
| @@ -33,6 +33,7 @@ We use the following categories for changes: | |||
| - Log warning when failing to write response to remote read requests [#1180] | |||
| - Fix Promscale running even when some component may fail to start [#1217] | |||
| - Fix `promscale_ingest_max_sent_timestamp_milliseconds` metric for tracing [#1270] | |||
| - Fix `prom_api.reset_metric_retention_period` on two-step continuous aggregates [#1294] | |||
There was a problem hiding this comment.
How is this a FIX? It's just a test change
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok. I've found a related extension change here https://github.com/timescale/promscale_extension/pull/180/files
But still let's add some description explaining the problem and the fix. From extension PR it seems there was some problem with SQL script (a wrong variable name) if I am not mistaken
There was a problem hiding this comment.
btw I am thinking if we should track extension changes in their own CHANGELOG? Obviously the fix in the extension can be released separately from Promscale connector so I am not sure why are we coupling these two? I am assuming that being able to release extension separately from connector is better (obviously in some cases that will not be possible...). Thoughts?
There was a problem hiding this comment.
In general I think that you're probably right. Until we get the 0.11.0 and 0.5.0 versions of the connector and the extension out though, their release is tied to one another.
In [1] we fixed some typos in the `reset_metric_retention_period` function which caused the function to break when used with two-step continuous aggregates. This change adds tests cases to exercise `reset_metric_retention_period` with two-step aggregates. [1]: timescale/promscale_extension#180
3c070a3 to
6467791
Compare
A couple of typos in this function broke it when used with two-step continuous aggregates. A companion change in the promscale repository adds a test to exercise this code path [1]. [1]: timescale/promscale#1294
A couple of typos in this function broke it when used with two-step continuous aggregates. A companion change in the promscale repository adds a test to exercise this code path [1]. [1]: timescale/promscale#1294
A couple of typos in this function broke it when used with two-step continuous aggregates. A companion change in the promscale repository adds a test to exercise this code path [1]. [1]: timescale/promscale#1294
A couple of typos in this function broke it when used with two-step continuous aggregates. A companion change in the promscale repository adds a test to exercise this code path [1]. [1]: timescale/promscale#1294
Description
In 1 we fixed some typos in the
reset_metric_retention_periodfunction which caused the function to break when used with two-step
continuous aggregates.
This change adds tests cases to exercise
reset_metric_retention_periodwith two-step aggregates.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:
Updated the relevant documentation