Skip to content

scheduler: fix anticount and improving the Robustness of Hotspot Statistics #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2021
Merged

scheduler: fix anticount and improving the Robustness of Hotspot Statistics #3928

merged 3 commits into from
Aug 2, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 30, 2021 •
edited
Loading

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

it is similiar with #3707, After getting the hot read peer information from store heartbeat, a region that previously took two minutes to get cold will take only 20 seconds to get cold, so that the balance leader scheduler will go to the balance hotspot for a more variable load.

for read-peer/write-peer/write-store, the period of filter is 5, but it is 3 for read store.

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
update
f65bf4c 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 30, 2021
@ti-chi-bot ti-chi-bot requested review from HunDunDM and Yisaer July 30, 2021 07:03
@lhy1024
fix test
aaeaab9 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 30, 2021
@lhy1024 lhy1024 marked this pull request as ready for review July 30, 2021 07:59
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #3928 (2120e9f) into master (8e14902) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
+ Coverage   74.55%   74.68%   +0.13%     
==========================================
  Files         246      246              
  Lines       25064    25068       +4     
==========================================
+ Hits        18686    18722      +36     
+ Misses       4713     4695      -18     
+ Partials     1665     1651      -14
Flag Coverage Δ
unittests 74.68% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/util.go 100.00% <ø> (ø)
server/statistics/hot_peer_cache.go 95.78% <100.00%> (+0.06%) ⬆️
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
server/member/member.go 63.10% <0.00%> (-3.75%) ⬇️
client/client.go 71.82% <0.00%> (-0.14%) ⬇️
server/tso/allocator_manager.go 67.44% <0.00%> (+0.33%) ⬆️
server/cluster/cluster.go 83.01% <0.00%> (+0.47%) ⬆️
client/base_client.go 84.89% <0.00%> (+0.52%) ⬆️
server/tso/tso.go 63.53% <0.00%> (+0.55%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e14902...2120e9f. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 2, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aaeaab9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@ti-chi-bot ti-chi-bot merged commit 141ab52 into tikv:master Aug 2, 2021
nolouch pushed a commit to nolouch/pd that referenced this pull request Aug 2, 2021
@lhy1024 @ti-chi-bot @nolouch
scheduler: fix anticount and improving the Robustness of Hotspot Stat…
12552c7 
…istics (tikv#3928)

* update

Signed-off-by: lhy1024 <admin@liudos.us>

* fix test

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@lhy1024 lhy1024 mentioned this pull request Aug 3, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@Yisaer Yisaer Yisaer approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhy1024 @ti-chi-bot @nolouch @Yisaer