statistics: adjust threshold for the Region read stats #3707
Conversation
Signed-off-by: yisaer <disxiaofei@163.com>
Codecov Report
@@ Coverage Diff @@
## master #3707 +/- ##
==========================================
- Coverage 74.94% 74.94% -0.01%
==========================================
Files 244 244
Lines 24408 24410 +2
==========================================
+ Hits 18292 18293 +1
+ Misses 4500 4496 -4
- Partials 1616 1621 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
server/cluster/cluster.go
Outdated
| // RegionStats is a thread-safe method | ||
| return c.hotStat.RegionStats(statistics.ReadFlow, c.GetOpts().GetHotRegionCacheHitsThreshold()) | ||
| // As read stats are reported by store heartbeat, the threshold needs to be multiplied by 6. | ||
| threshold := c.GetOpts().GetHotRegionCacheHitsThreshold() * 6 |
There was a problem hiding this comment.
replace 6 with writeInterval/readInterval?
Signed-off-by: yisaer <disxiaofei@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 6ed3c19
|
|
@Yisaer: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/run-integration-common-test |
Signed-off-by: yisaer disxiaofei@163.com
What problem does this PR solve?
Close #3701
What is changed and how it works?
Adjust the threshold for the threshold for the read stats.
Release note