Skip to content

*: fix default log file size #9038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

*: fix default log file size #9038

merged 1 commit into from
Feb 7, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 6, 2025

What problem does this PR solve?

Issue Number: Close #9037

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx
fix default log file size
2b01efc 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (f6d4ca5) to head (2b01efc).
Report is 64 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9038      +/-   ##
==========================================
+ Coverage   76.20%   76.29%   +0.09%     
==========================================
  Files         467      467              
  Lines       71101    71113      +12     
==========================================
+ Hits        54182    54259      +77     
+ Misses      13534    13479      -55     
+ Partials     3385     3375      -10
Flag Coverage Δ
unittests 76.29% <60.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx rleungx requested review from JmPotato and lhy1024 February 6, 2025 09:16
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 12:26:23.920042375 +0000 UTC m=+361055.452454358: ☑️ agreed by JmPotato.
  • 2025-02-07 03:13:11.868268892 +0000 UTC m=+414263.400680875: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 0c43ce5 into tikv:master Feb 7, 2025
24 of 26 checks passed
@rleungx rleungx deleted the fix-log-size branch February 7, 2025 03:37
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 10, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 10, 2025
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#9038
e692661 
close tikv#9037

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9054.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 10, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Feb 10, 2025
@ti-chi-bot @rleungx
*: fix default log file size (#9038) (#9054)
0af6fbc 
close #9037

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 14, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9192.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 14, 2025
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/pd#release-8.5 from head ti-chi-bot:cherry-pick-9038-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-9038-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

ti-chi-bot bot added a commit that referenced this pull request Apr 15, 2025
@ti-chi-bot @rleungx @ti-chi-bot
*: fix default log file size (#9038) (#9192)
113417e 
close #9037

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default max-size of log file is changed
4 participants
@rleungx @ti-chi-bot @JmPotato @lhy1024