Skip to content

*: fix default log file size (#9038) #9054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

*: fix default log file size (#9038) #9054

merged 2 commits into from
Feb 10, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9038

What problem does this PR solve?

Issue Number: Close #9037

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#9038
e692661 
close tikv#9037

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 10, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 10, 2025
Merged
@ti-chi-bot
Copy link
Member Author

@rleungx This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@rleungx
resolve conflicts
4fff2e9 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 10, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 10, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 10, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 09:58:33.837700036 +0000 UTC m=+264156.233922097: ☑️ agreed by lhy1024.
  • 2025-02-10 09:58:37.880608483 +0000 UTC m=+264160.276830544: ☑️ agreed by JmPotato.

@rleungx
Copy link
Member

rleungx commented Feb 10, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0af6fbc into tikv:release-7.5 Feb 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees

@rleungx rleungx

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @rleungx @JmPotato @lhy1024