Skip to content

client: fix backoffer initialization #9012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2025
Merged

client: fix backoffer initialization #9012

merged 3 commits into from
Jan 22, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #9013. ref #8835.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2025
@rleungx
fix backoffer initialization
5247c1e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.28%. Comparing base (6cadbe7) to head (b117d30).
Report is 199 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9012      +/-   ##
==========================================
+ Coverage   76.25%   76.28%   +0.03%     
==========================================
  Files         466      466              
  Lines       70733    70733              
==========================================
+ Hits        53938    53962      +24     
+ Misses      13437    13411      -26     
- Partials     3358     3360       +2
Flag Coverage Δ
unittests ∅ <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 20, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 20, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-20 07:25:38.582322245 +0000 UTC m=+79265.913241698: ☑️ agreed by JmPotato.
  • 2025-01-20 07:38:44.227061786 +0000 UTC m=+80051.557981187: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 5a5c07e into tikv:master Jan 22, 2025
25 checks passed
@rleungx rleungx deleted the backoff-setting branch January 22, 2025 08:42
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 14, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 14, 2025
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#9012
f1d6433 
ref tikv#8835, close tikv#9013

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9545.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2025
Open
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 14, 2025
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#9012
b00962e 
ref tikv#8835, close tikv#9013

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9546.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backoffer initialization is unexpected
4 participants
@rleungx @ti-chi-bot @JmPotato @nolouch