Skip to content

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #8947.

What is changed and how does it work?

Init the ticker directly when TSO Follower Proxy is already enabled.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Dec 25, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 25, 2024
@JmPotato JmPotato force-pushed the fix_enable_tso_follower_proxy branch from f2bf3ed to 1246ed9 Compare December 25, 2024 07:04
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the fix_enable_tso_follower_proxy branch from 1246ed9 to 535b3c2 Compare December 25, 2024 07:11
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (054a3d4) to head (d99712c).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8948      +/-   ##
==========================================
- Coverage   76.29%   76.29%   -0.01%     
==========================================
  Files         463      463              
  Lines       70452    70458       +6     
==========================================
+ Hits        53754    53756       +2     
- Misses      13352    13356       +4     
  Partials     3346     3346              
Flag Coverage Δ
unittests 76.29% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 07:25:16.81658827 +0000 UTC m=+1632906.905390814: ☑️ agreed by rleungx.
  • 2024-12-25 07:47:08.518722096 +0000 UTC m=+1634218.607524640: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 95bfbe6 into tikv:master Dec 25, 2024
25 checks passed
@JmPotato JmPotato deleted the fix_enable_tso_follower_proxy branch December 25, 2024 08:36
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 26, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 26, 2025
close tikv#8947

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9025.

ti-chi-bot bot added a commit that referenced this pull request Jan 27, 2025
#8948) (#9025)

close #8947

Init the ticker directly when TSO Follower Proxy is already enabled.

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 11, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 11, 2025
close tikv#8947

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9058.

ti-chi-bot bot added a commit that referenced this pull request Feb 11, 2025
#8948) (#9058)

close #8947

Init the ticker directly when TSO Follower Proxy is already enabled.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 15, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 15, 2025
close tikv#8947

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9198.
But this PR has conflicts, please resolve them!

ti-chi-bot bot added a commit that referenced this pull request Apr 16, 2025
#8948) (#9198)

close #8947

Init the ticker directly when TSO Follower Proxy is already enabled.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <github@ipotato.me>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Co-authored-by: JmPotato <github@ipotato.me>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change EnableTSOFollowerProxy may not take effect
4 participants