Skip to content

client/tso: init the ticker when TSO Follower Proxy is already enabled (#8948) #9058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2025
Merged

client/tso: init the ticker when TSO Follower Proxy is already enabled (#8948) #9058

merged 3 commits into from
Feb 11, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8948

What problem does this PR solve?

Issue Number: close #8947.

What is changed and how does it work?

Init the ticker directly when TSO Follower Proxy is already enabled.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#8948
2657ebe 
close tikv#8947

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2025
Merged
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@JmPotato
Adopt the fix
3bfa21e 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 07:37:28.132332749 +0000 UTC m=+342090.528554812: ☑️ agreed by JmPotato.
  • 2025-02-11 07:43:00.332950019 +0000 UTC m=+342422.729172077: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JmPotato,bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ce2d0f1 into tikv:release-7.5 Feb 11, 2025
21 checks passed
@JmPotato JmPotato deleted the cherry-pick-8948-to-release-7.5 branch February 11, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@bufferflies bufferflies bufferflies approved these changes

@rleungx rleungx rleungx approved these changes

Assignees

@JmPotato JmPotato

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @JmPotato @bufferflies @rleungx