Skip to content

Metrics: Go runtime metrics #8927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 19, 2024
Merged

Metrics: Go runtime metrics #8927

merged 10 commits into from
Dec 19, 2024

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 17, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8931

What is changed and how does it work?

Using promtheus clieng golang mod to expose go runtime metrics.
how to see this:

tiup playground nightly --pd.mode ms --tiflash 0 --kv 3 --pd 1 --db 1 --tso 2 --scheduling 1 --tso.binpath ./bin/pd-server --scheduling.binpath ./bin/pd-server --pd.binpath ./bin/pd-server

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image

Code changes

Side effects

Related changes

Release note

expose golang runtime metrics

@bufferflies
upgrade prom http to 1.20.5
dc5acb4 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
replace
5d1a4ec 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
replace etcd
2a97d6d 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
replca
590b723 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
go runtime report
44e91e4 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 17, 2024
@bufferflies
remove unused code
8e93aab 
Signed-off-by: bufferflies <1045931706@qq.com>
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (da4b43a) to head (1e2b369).
Report is 227 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8927      +/-   ##
==========================================
- Coverage   76.29%   76.25%   -0.04%     
==========================================
  Files         462      462              
  Lines       70429    70436       +7     
==========================================
- Hits        53735    53714      -21     
- Misses      13346    13369      +23     
- Partials     3348     3353       +5
Flag Coverage Δ
unittests 76.25% <100.00%> (-23.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 18, 2024
@bufferflies
add grafana panel
1c0efef 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2024
@bufferflies bufferflies marked this pull request as ready for review December 18, 2024 07:42
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@bufferflies bufferflies changed the title Go runtime metrics Metrics: Go runtime metrics Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-18 11:12:15.673006222 +0000 UTC m=+1041725.761808764: ☑️ agreed by nolouch.
  • 2024-12-19 03:00:08.917411499 +0000 UTC m=+1098599.006214043: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot removed type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-7.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-7.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-6.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-8.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies bufferflies added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Apr 28, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 28, 2025
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#8927
7f766fe 
close tikv#8931

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 28, 2025
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#8927
e1382a1 
close tikv#8931

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9280.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9281.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 28, 2025
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#8927
3f28748 
close tikv#8931

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Apr 28, 2025
Open
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9282.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 28, 2025
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#8927
2ef6296 
close tikv#8931

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Apr 28, 2025
Open
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9283.
But this PR has conflicts, please resolve them!

@bufferflies
Copy link
Contributor Author

pick 8.5 after version 8.5.2 released

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 7, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9496.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 8, 2025
@ti-chi-bot @bufferflies
Metrics: Go runtime metrics (#8927) (#9281)
de3246b 
close #8931

Signed-off-by: 童剑 <1045931706@qq.com>

Co-authored-by: 童剑 <1045931706@qq.com>
Co-authored-by: tongjian <1045931706@qq.com>
ti-chi-bot bot added a commit that referenced this pull request Jul 9, 2025
@ti-chi-bot @bufferflies @ti-chi-bot
Metrics: Go runtime metrics (#8927) (#9496)
6e610b9 
close #8931

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd support to report runtime metrics to prometheues
4 participants
@bufferflies @ti-chi-bot @nolouch @lhy1024