Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8927

What problem does this PR solve?

Issue Number: Close #8931

What is changed and how does it work?

Using promtheus clieng golang mod to expose go runtime metrics.
how to see this:

tiup playground nightly --pd.mode ms --tiflash 0 --kv 3 --pd 1 --db 1 --tso 2 --scheduling 1 --tso.binpath ./bin/pd-server --scheduling.binpath ./bin/pd-server --pd.binpath ./bin/pd-server

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image

Code changes

Side effects

Related changes

Release note

expose golang runtime metrics 

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 7, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 7, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 8, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-08 06:47:43.347836814 +0000 UTC m=+1982316.071015798: ☑️ agreed by lhy1024.
  • 2025-07-08 07:18:37.009847399 +0000 UTC m=+1984169.733026380: ☑️ agreed by rleungx.

@bufferflies
Copy link
Contributor

/retest

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.64%. Comparing base (7ae6661) to head (43c5059).
Report is 1 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9496      +/-   ##
===============================================
+ Coverage        75.58%   75.64%   +0.06%     
===============================================
  Files              463      463              
  Lines            72473    72480       +7     
===============================================
+ Hits             54780    54829      +49     
+ Misses           14183    14148      -35     
+ Partials          3510     3503       -7     
Flag Coverage Δ
unittests 75.64% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit 6e610b9 into tikv:release-8.5 Jul 9, 2025
26 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants