Version Activation/Deactivation timestamps + sync information with version local state #7736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
May 8, 2025
Shivs11
commented
May 8, 2025
Shivs11
commented
May 8, 2025
Shivs11
commented
May 8, 2025
carlydf
reviewed
May 8, 2025
go.mod
Outdated
| @@ -177,3 +177,5 @@ require ( | |||
| modernc.org/strutil v1.2.1 // indirect | |||
| modernc.org/token v1.1.0 // indirect | |||
| ) | |||
|
|
|||
| replace go.temporal.io/api => github.com/temporalio/api-go v1.48.1-0.20250508163833-6d907c430e54 | |||
carlydf
reviewed
May 13, 2025
|
|
||
| // Preserve create_time and first_activation_time if they exist in current summary. This is to ensure that if the version | ||
| // had already been activated before, we don't override the first activation time by setting it to a wrong value. | ||
| if existingSummary := d.State.Versions[summary.GetVersion()]; existingSummary != nil && existingSummary.GetCreateTime() != nil { |
There was a problem hiding this comment.
Suggested change
| if existingSummary := d.State.Versions[summary.GetVersion()]; existingSummary != nil && existingSummary.GetCreateTime() != nil { | |
| if existingSummary := d.State.Versions[summary.GetVersion()]; existingSummary.GetCreateTime() != nil { |
carlydf
approved these changes
May 13, 2025
Shivs11
added a commit
to temporalio/api
that referenced
this pull request
May 14, 2025
…on timestamps (#585) _**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Added two new timestamps to signify when a version first/last receives traffic in the `WorkerDeploymentVersionInfo` and `WorkerDeploymentInfo`. Added missing fields from VersionLocalState that were not present in VersionSummary. <!-- Tell your future self why have you made these changes --> **Why?** - Adding the two new timestamps shall allow operators to have more visibility into when a version gets activated/deactivated. - The reason fields from `VersionLocalState` were added to the `VersionSummary` is because the UI, right now, is querying a bunch of different places to get information about a specific version. This might be annoying and the aim of this PR is to make VersionSummary the source of truth for information related to a specific version. A nice cherry on top is that this shall also reduce the number of API calls to get information about a version. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - temporalio/temporal#7736)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
May 14, 2025
…on timestamps (#585) _**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Added two new timestamps to signify when a version first/last receives traffic in the `WorkerDeploymentVersionInfo` and `WorkerDeploymentInfo`. Added missing fields from VersionLocalState that were not present in VersionSummary. <!-- Tell your future self why have you made these changes --> **Why?** - Adding the two new timestamps shall allow operators to have more visibility into when a version gets activated/deactivated. - The reason fields from `VersionLocalState` were added to the `VersionSummary` is because the UI, right now, is querying a bunch of different places to get information about a specific version. This might be annoying and the aim of this PR is to make VersionSummary the source of truth for information related to a specific version. A nice cherry on top is that this shall also reduce the number of API calls to get information about a version. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - temporalio/temporal#7736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
routing_update_time,current_since_time,ramping_since_time,DrainageInfoas part of VersionSummary.Why?
How did you test it?