VersionLocalState in sync with VersionSummary + Activation/Deactivation timestamps #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
approved these changes
May 8, 2025
Sushisource
approved these changes
May 8, 2025
| // aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --) | ||
| google.protobuf.Timestamp ramping_since_time = 6; | ||
| // Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed. | ||
| google.protobuf.Timestamp routing_update_time = 7; |
There was a problem hiding this comment.
nit: last_routing_update_time for clarity?
There was a problem hiding this comment.
Thanks for the suggestion! Hmm, I still am leaning towards routing_update_time since the word 'update' already implies the latest change, so adding last_ felt a bit redundant to me.
Not making this change right now, but let me know if you still feel strongly about this.
ShahabT
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
WorkerDeploymentVersionInfoandWorkerDeploymentInfo.Added missing fields from VersionLocalState that were not present in VersionSummary.
Why?
VersionLocalStatewere added to theVersionSummaryis because the UI, right now, is querying a bunch of different places to get information about a specific version. This might be annoying and the aim of this PR is to make VersionSummary the source of truth for information related to a specific version. A nice cherry on top is that this shall also reduce the number of API calls to get information about a version.Breaking changes
Server PR