[desktop] Catch Windows notification exceptions #9400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
charlag
approved these changes
Jul 29, 2025
This removes some duplicate code and adds a convenient way to trigger a submission from the textbox.
Have the 2FA dialog and editor submit the OTP when the return key is pressed rather than when a button is clicked. Closes #8982
55ad001 to
e60b179
Compare
There isn't a clear explanation for why these can throw, but the library we use for Windows notifications does conveniently wrap them into JS exceptions. Closes #9399
e60b179 to
896279e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a clear explanation for why these can throw, but the library we use for Windows notifications does conveniently wrap them into JS exceptions.
Closes #9399