-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Publish v4.4.1 #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Publish v4.4.1 #2451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced broken search.azlyrics.com URL - Changed Request Headers to avoid bot detection
- Replaced broken search.azlyrics.com URL - Changed Request Headers to avoid bot detection This pull requests addresses #2441 where AZLyrics provider was broken and could not retrieve lyrics at all. ## How Has This Been Tested? Tested running the provider directly with various songs. Although a more thorough testing is suggested. ## Types of Changes ## Checklist - [x] My code follows the code style of this project - [ ] My change requires a change to the documentation - [x] I have updated the documentation accordingly - [x] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have added tests to cover my changes - [x] All new and existing tests passed
# Title <!--- Provide a general summary of your changes in the Title above --> ## Description * Prevent duplicate m3u entries on detect_formats * Prevent IndexError when attempting to create default named m3u file with no playlist. ## Related Issue #2446 #2448 ## How Has This Been Tested? todo: run m3u tests. ## Screenshots (if appropriate) ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project - [ ] My change requires a change to the documentation - [ ] I have updated the documentation accordingly - [ ] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed
# Title Remove Genius lyric header ## Description As of Aug 2025, Genius has added a lyrics header div. Remove it if present. `<div data-exclude-from-selection="true" class="LyricsHeader__Container-sc-5e4b7146-1 hFsUgC">` ## Related Issue Resolves #2356 ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project - [ ] My change requires a change to the documentation - [ ] I have updated the documentation accordingly - [x] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed
Solved index errors on mypy in the AZLyrics provider ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? Running mypy following CONTRIBUTING.md ## Screenshots (if appropriate) ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project - [ ] My change requires a change to the documentation - [ ] I have updated the documentation accordingly - [x] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Full Changelog: v4.4.0...v4.4.1