Skip to content

Conversation

fer-hnndz
Copy link
Contributor

@fer-hnndz fer-hnndz commented Aug 16, 2025

Solved index errors on mypy in the AZLyrics provider

Related Issue

Motivation and Context

How Has This Been Tested?

Running mypy following CONTRIBUTING.md

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed

@Silverarmor
Copy link
Member

Silverarmor commented Aug 17, 2025

spotdl/providers/lyrics/azlyrics.py:111: error: Item "PageElement" of "PageElement | Tag | NavigableString" has no attribute "get"  [union-attr]
Found 6 errors in 1 file (checked 55 source files)
spotdl/providers/lyrics/azlyrics.py:111: error: Item "NavigableString" of "PageElement | Tag | NavigableString" has no attribute "get"  [union-attr]
spotdl/providers/lyrics/azlyrics.py:111: error: Item "AttributeValueList" of "Any | str | AttributeValueList | None" has no attribute "strip"  [union-attr]
spotdl/providers/lyrics/azlyrics.py:111: error: Item "None" of "Any | str | AttributeValueList | None" has no attribute "strip"  [union-attr]
spotdl/providers/lyrics/azlyrics.py:116: error: Item "None" of "PageElement | None" has no attribute "get_text"  [union-attr]
spotdl/providers/lyrics/azlyrics.py:117: error: Item "None" of "PageElement | None" has no attribute "get_text"  [union-attr]

do you want me to ignore union-attr errors?

@Silverarmor Silverarmor merged commit 37ca382 into dev Aug 19, 2025
2 of 16 checks passed
@Silverarmor Silverarmor mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants