-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH] Resnet classifier #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Resnet classifier #3365
Conversation
@AurumnPegasus can you please help me fix test cases |
The issue does not seem to be in the code (atleast for now, will know more when those tests are executed) but from code quality. Once you have done that, ensure you run In my opinion, I think you are skipping the |
@nilesh05apr, as @AurumnPegasus said, you need to follow code formatting standards. How-to is outlined on this developer page: For quick inspection, you can also check the "details" next to the failed CI element "Install and test / code-quality (pull_request)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
Hey @nilesh05apr, do you still want to work on this? I'd had users ask me when this would be available in I'll be happy to extend any support to you if required. Thanks. |
@achieveordie thanks for asking. I am working on it, but some tests are failing. let me try if it's not so urgent. |
Absolutely! Solving the failure due to Once you've done that you can make any slight change (like an additional space in the docstring) in your PR and commit it. PS: I'd recommend resolving conflicts first. |
@achieveordie , @AurumnPegasus i have added new pr as old one got clumsy. |
sktime#6038) #### Reference Issues/PRs Part of sktime#3351. See also sktime#3365 #### What does this implement/fix? Explain your changes. Migrated CNTC, InceptionTime, and MACNN regressors to sktime from sktime-dl
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
No
PR checklist
For all contributions
For new estimators