Skip to content

[ENH] Resnet classifier #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[ENH] Resnet classifier #3365

wants to merge 5 commits into from

Conversation

nilesh05apr
Copy link
Contributor

@nilesh05apr nilesh05apr commented Aug 29, 2022

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

No

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@nilesh05apr
Copy link
Contributor Author

@AurumnPegasus can you please help me fix test cases

@AurumnPegasus
Copy link
Contributor

The issue does not seem to be in the code (atleast for now, will know more when those tests are executed) but from code quality.
Ensure that you have followed instructions for dev installation as mentioned in the guide

Once you have done that, ensure you run pre-commit when you stage files for changes (BEFORE committing anything). Once the pre-commit tests pass, then commit your changes and push them to your branch.

In my opinion, I think you are skipping the pre-commit step, so let me know if it resolves your blocker

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 11, 2022

@nilesh05apr, as @AurumnPegasus said, you need to follow code formatting standards. How-to is outlined on this developer page:
https://www.sktime.org/en/stable/developer_guide/coding_standards.html

For quick inspection, you can also check the "details" next to the failed CI element "Install and test / code-quality (pull_request)"

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@achieveordie
Copy link
Collaborator

Hey @nilesh05apr, do you still want to work on this? I'd had users ask me when this would be available in sktime and since you're almost done I wanted to nudge you regarding it.

I'll be happy to extend any support to you if required.

Thanks.

@nilesh05apr
Copy link
Contributor Author

@achieveordie thanks for asking. I am working on it, but some tests are failing. let me try if it's not so urgent.

@achieveordie
Copy link
Collaborator

Absolutely!

Solving the failure due to code-quality check is actually very trivial. As per this comment on this thread, you need to set up your dev setup properly.

Once you've done that you can make any slight change (like an additional space in the docstring) in your PR and commit it. pre-commit will then run and help you rectify problems relating to code formatting.

PS: I'd recommend resolving conflicts first.

@nilesh05apr
Copy link
Contributor Author

@achieveordie , @AurumnPegasus i have added new pr as old one got clumsy.
please check test results for fix: pre-commit errors #3881

fkiraly pushed a commit that referenced this pull request Dec 11, 2022
Part of #3351. See also #3365 

Migrates `ResNetClassifier` from `sktime-dl` to `sktime`
fkiraly pushed a commit that referenced this pull request Feb 26, 2024
#### Reference Issues/PRs
Part of #3351. See also
#3365

#### What does this implement/fix? Explain your changes.
Migrated FCN, MLP and LSTMFCN regressors to sktime from sktime-dl
@nilesh05apr nilesh05apr deleted the resnet branch February 27, 2024 16:22
fkiraly pushed a commit that referenced this pull request Mar 2, 2024
#6038)

#### Reference Issues/PRs
Part of #3351. See also
#3365

#### What does this implement/fix? Explain your changes.
Migrated CNTC, InceptionTime, and MACNN regressors to sktime from
sktime-dl
fnhirwa pushed a commit to fnhirwa/sktime that referenced this pull request Mar 6, 2024
sktime#6038)

#### Reference Issues/PRs
Part of sktime#3351. See also
sktime#3365

#### What does this implement/fix? Explain your changes.
Migrated CNTC, InceptionTime, and MACNN regressors to sktime from
sktime-dl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants