Skip to content

[ENH] Migrate DL regressors from sktime-dl: FCN, LSTMFCN, MLP #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 26, 2024
Merged

[ENH] Migrate DL regressors from sktime-dl: FCN, LSTMFCN, MLP #6001

merged 7 commits into from
Feb 26, 2024

Conversation

nilesh05apr
Copy link
Contributor

Reference Issues/PRs

Part of #3351. See also #3365

What does this implement/fix? Explain your changes.

Migrated FCN, MLP and LSTMFCN regressors to sktime from sktime-dl

Does your contribution introduce a new dependency? If yes, which one?

No

Did you add any tests for the change?

None yet

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly changed the title [ENH] Migrate DL Estimators from sktime-dl to sktime [ENH] Migrate DL regressors from sktime-dl: FCN, LSTMFCN, MLP Feb 25, 2024
@fkiraly fkiraly added module:regression regression module: time series regression enhancement Adding new functionality labels Feb 25, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing, can you please also add these to the API reference?

In regression.rst

@nilesh05apr
Copy link
Contributor Author

@fkiraly what changes I need to do?

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 26, 2024

I made them already so this can be in the release, don´t worry

@fkiraly fkiraly merged commit 78c61e0 into sktime:main Feb 26, 2024
@nilesh05apr nilesh05apr deleted the sktime-dl branch February 27, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:regression regression module: time series regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants