Keep track of config_dir #1766
Merged
Keep track of config_dir #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 36 36
Lines 4658 4659 +1
=======================================
+ Hits 4270 4271 +1
Misses 388 388
Continue to review full report at Codecov.
|
|
This is a good idea, thanks. |
simonw
added a commit
that referenced
this pull request
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1764
Small change that adds
self.config_dir = config_dirtoDatasette.__init__. This will let plugins also useconfig_dir, if available.