Add timeout option to Cloudrun build #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1717 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 34 34
Lines 4574 4575 +1
=======================================
+ Hits 4197 4198 +1
Misses 377 377
Continue to review full report at Codecov.
|
|
This is a neat feature, thanks! |
simonw
added a commit
that referenced
this pull request
Apr 24, 2022
simonw
added a commit
that referenced
this pull request
Apr 24, 2022
simonw
added a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that the Cloudrun build phase often hits a timeout limit with large databases. I believe the default timeout is 10 minutes. This pull request just adds a
--timeoutoption to the cloudrunpublishcommand and passes the value on to the build step.