Convert lastModified() calls to the more precise getModifiedTime() #3789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2017
|
I need a place to run exactly once, during startup, a quick test in the source directory in order to check for the availability of precise timestamps. Something like: It can be done at any stage during startup. If native support for milliseconds is not available on that filesystem or OS, it will generate an informational message like: It can be either logged as a debug or info level message. Any suggestions as to the best place to place this line? @eed3si9n @dwijnand |
|
Please do not merge yet |
dwijnand
reviewed
Dec 13, 2017
added 7 commits
December 14, 2017 12:17
This reverts commit 4ac231d.
This reverts commit 3c5aaca.
In Eval there is a calculation of hashes by scanning the elements of classpath, and getting the last modification time of each directory. When lastModified() was in use, non-existent elements would return 0L, but getModifiedTime() will throw an exception instead (like getLastModifiedTime(), incidentally). So, we catch the FileNotFoundException and return 0L now as well.
It turns out the code in Sync.scala activiely tries to transfer the invalid modifed time of non-existent files in the source directory over the time of the target file, which may or may not exist. In case it exists, the modification time is set to January 1, 1970. This is arguably a bug in Sync, which should be adjusted to better handle mappings with source files that do not exist. For now, however, we preserve the current behavior, using the deprecated copyLastModified().
dwijnand
approved these changes
Dec 15, 2017
|
Superseded by #3816. |
|
The validator has checked the following projects against Scala 2.12, 2.11,
❌ The result is: FAILED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new native file modification timestamps, which return times with full millisecond precisions whenever possible. Re-enables the tests run/error and tests/fork-parallel.
Depends on sbt/zinc#463
See: sbt/io#92
Fixes #3543
Fixes #3545