This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Convert lastModified() calls to the more precise getModifiedTime() #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastModified() calls to the more precise getModifiedTime()FileInfo is used to wrap information like last modified time on files that may or may not exist. Arguably, that does not make much sense: the non-existent files should not lead to modification file information, hashes, and a persistent serialized version of the resulting meaningless information. However, considering that the FileInfo information is serialized and saved, it is necessary to preserve compatibility at this stage. Therefore the modification time is explicitly set to zero for those files that do not exist when each FileInfo is built.
.. and make getModifiedTimeOrZero private.
added 2 commits
December 15, 2017 17:20
Use IO.getModified over importing the method
dwijnand
previously approved these changes
Dec 15, 2017
eed3si9n
approved these changes
Dec 15, 2017
|
The validator has checked the following projects against Scala 2.12, 2.11,
❌ The result is: FAILED |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new native file modification timestamps, which return times with full millisecond precisions whenever possible. Depends on sbt/io#92