gui: Actually filter scope ID out of IPv6 address when using Remote GUI (ref #8084) #9688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UI (ref syncthing#8084) The current code does not work, because it uses a string in the replace() method instead of regex. Thus, change it to a proper regex. Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
|
Not sure how this slipped in, but it shows how much I myself use this functionality… Encountered the problem today, after 2 years, and was wondering why the IPv6 address had a scope ID in it even though it was supposed to be filtered out. Also, a side note, but Mozilla declined to implement scope ID addresses in https://bugzilla.mozilla.org/show_bug.cgi?id=700999#c111, so they don't work in any modern browser right now, i.e. they are useless if the scope ID isn't filtered out. |
acolomb
approved these changes
Sep 8, 2024
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 11, 2024
* main: gui, man, authors: Update docs, translations, and contributors gui: Actually filter scope ID out of IPv6 address when using Remote GUI (ref syncthing#8084) (syncthing#9688) Revert "lib/fs: Put the caseFS as the outermost layer (syncthing#9648)" lib/api: Correct ordering of Accept-Language codes by weight (fixes syncthing#9670) (syncthing#9671) gui, man, authors: Update docs, translations, and contributors gui: Fix incorrect UI language auto detection (fixes syncthing#9668) (syncthing#9669) lib/model, lib/protocol: Index sending/receiving debugging (syncthing#9657) lib/upgrade: Send OS version header to upgrade server (syncthing#9663) lib/upgrade: Send OS version header to upgrade server (syncthing#9663) gui, man, authors: Update docs, translations, and contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gui: Actually filter scope ID out of IPv6 address when using Remote GUI (ref #8084)
The current code does not work, because it uses a string in the
replace() method instead of regex. Thus, change it to a proper regex.
Signed-off-by: Tomasz Wilczyński twilczynski@naver.com