lib/fs: Put the caseFS as the outermost layer #9648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning in comments. The main motivation is to avoid all the case checks when walking the filesystem.
|
I share that cursive feeling. I was pondering adding something like "I was wrong before, and I am right now - trust me" to the commit message... |
|
Yeah we'll see, won't we 🤨 |
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Aug 19, 2024
* main: (46 commits) build: use Go 1.23, require minimum 1.22 (syncthing#9651) gui, man, authors: Update docs, translations, and contributors lib/fs: Put the caseFS as the outermost layer (syncthing#9648) gui: Add Irish (ga) translation template (syncthing#9646) gui, man, authors: Update docs, translations, and contributors lib/syncthing: Add wrapper for access to model (syncthing#9627) cli: Remove `go-shlex` dependency (syncthing#9644) lib/sha256: Remove it (syncthing#9643) build: Update dependencies (syncthing#9640) Chmod -x non-executable files (fixes syncthing#9629) (syncthing#9630) gui, man, authors: Update docs, translations, and contributors all: minimal set of changes for iOS app (syncthing#9619) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors etc: Remove restart on suspend systemd service (ref syncthing#8448) (syncthing#9611) gui, man, authors: Update docs, translations, and contributors lib/fs: Add missing locks to fakeFile methods (fixes syncthing#9499) (syncthing#9603) lib/api: Increase test request timeout (fixes syncthing#9455) (syncthing#9602) gui, man, authors: Update docs, translations, and contributors lib/ignore: Remove unused patterns in cache (syncthing#9601) ...
calmh
added a commit
that referenced
this pull request
Sep 6, 2024
calmh
added a commit
that referenced
this pull request
Sep 6, 2024
* release: Revert "lib/fs: Put the caseFS as the outermost layer (#9648)"
|
Reverted in v1.27.12. It seems it also broke my Syncthing instances: when one device deleted a file, another device displayed an error: and the deleted file was restored. I was planning to send a bug report, but this seems to be fixed in v1.27.12, so I'm just leaving this note here |
imsodin
added a commit
to imsodin/syncthing
that referenced
this pull request
Sep 7, 2024
Reasoning in comments. The main motivation is to avoid all the case checks when walking the filesystem.
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 11, 2024
* main: gui, man, authors: Update docs, translations, and contributors gui: Actually filter scope ID out of IPv6 address when using Remote GUI (ref syncthing#8084) (syncthing#9688) Revert "lib/fs: Put the caseFS as the outermost layer (syncthing#9648)" lib/api: Correct ordering of Accept-Language codes by weight (fixes syncthing#9670) (syncthing#9671) gui, man, authors: Update docs, translations, and contributors gui: Fix incorrect UI language auto detection (fixes syncthing#9668) (syncthing#9669) lib/model, lib/protocol: Index sending/receiving debugging (syncthing#9657) lib/upgrade: Send OS version header to upgrade server (syncthing#9663) lib/upgrade: Send OS version header to upgrade server (syncthing#9663) gui, man, authors: Update docs, translations, and contributors
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Mar 20, 2025
* main: lib/fs: Put the caseFS as the outermost layer (syncthing#9648)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning in comments. The main motivation is to avoid all the case checks when walking the filesystem.