Replace Yarn Berry by PNPM #2932

Kocal · 2025-07-20T14:45:23Z

Q	A
Bug fix?	no
New feature?	no
Docs?	no
Issues	Fix #...
License	MIT

Purely internal, this PR replaces Yarn by PNPM for the following reasons:

when working on Migrate from Yarn Classic to Yarn Berry #2222, I tried to use PNPM instead but it was not possible to not install Swup "dev"-dependencies, this is now possible
it is more efficient and performant, and better for your disk
it has more features, better Workspaces support and Catalogs 🤩
commands to release packages on npm are simpler

For developers working on UX, pnpm can be installed with Corepack

Note: the ~26k lines changed are mainly about lock files

github-actions · 2025-07-20T14:45:47Z

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

File	Before (Size / Gzip)	After (Size / Gzip)
Autocomplete
`controller.js`	`17.6 kB` / `4.12 kB`	`17.61 kB`^0% / `4.13 kB`^0%

Kocal · 2025-07-20T16:01:22Z

.github/workflows/release-on-npm.yaml

-          - name: Replace local "workspace:*" occurrences
-            run: |
-              yarn workspaces foreach -pA exec "sed -i 's/\"workspace:\*\"/\"${{ env.VERSION }}\"/g' package.json"
-


This is automatically done when running pnpm publish, see https://pnpm.io/workspaces#publishing-workspace-packages

Kocal · 2025-07-21T07:02:48Z

package.json

-        "@testing-library/dom": "^10.4.0",
-        "@testing-library/jest-dom": "^6.6.3",
-        "@testing-library/user-event": "^14.6.1",
+        "@testing-library/dom": "catalog:",


Catalogs are like an alias to a constraint version.
When defining the catalog version for @testing-library/dom, then it will always install the exact same version when installing the same package in different places (if we use the same catalog ofc)

Kocal · 2025-07-21T07:04:38Z

src/Autocomplete/assets/package.json

+        "@testing-library/dom": "catalog:",
+        "@testing-library/jest-dom": "catalog:",
+        "@testing-library/user-event": "catalog:",
+        "jsdom": "catalog:",
        "tom-select": "^2.2.2",
+        "tslib": "catalog:",
+        "tsx": "catalog:",
+        "typescript": "catalog:",
+        "vitest": "catalog:",


Adding the (dev) dependencies used by the package instead of relying of packages installed from parents directories (that "magically" works with Yarn) is a good practice.

By using catalog:, we will have the same exact version of the dependency installed everywhere (consistency).

Kocal · 2025-07-21T07:04:56Z

src/React/assets/src/register_controller.ts

@@ -7,6 +7,8 @@
 * file that was distributed with this source code.
 */

+/// <reference types="@types/webpack-env" />


Otherwise __WebpackModuleApi was not found

Kocal · 2025-07-21T07:05:19Z

src/Map/src/Bridge/Google/assets/src/map_controller.ts

@@ -7,6 +7,8 @@
 * file that was distributed with this source code.
 */

+/// <reference types="google.maps" />


Otherwise google type was not found

Kocal · 2025-07-21T08:09:24Z

.github/workflows/app-tests.yaml

-            YARN_ENABLE_HARDENED_MODE: 0
-            YARN_ENABLE_IMMUTABLE_INSTALLS: 0
+        - working-directory: test_apps/encore-app
+          run: pnpm install --ignore-workspace


--ignore-workspace allows to ignore the pnpm-workspace.yaml from parent folders, and install dependencies from test_apps/encore-app only (test_apps/encore-app is not a workspace on purpose)

smnandre · 2025-07-21T09:27:55Z

What does it mean for the contributors?

smnandre · 2025-07-21T09:29:47Z

Nice job and i’m all in to leave legacy yarn :)

Kocal · 2025-07-21T09:35:50Z

What does it mean for the contributors?

pnpm will be automatically installed when running corepack enable, which we already explain in our CONTRIBUTING.md. And of course, commands like yarn install or yarn build won't work anymore, in favor of pnpm install, pnpm build, etc...

kbond

Good arguments for this change!

…PM, as it breaks installation from `vendor/` PHP packages (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no  | Docs? | no  | Issues | Fix #2951  | License | MIT  Since #2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages

…from PNPM, as it breaks installation from `vendor/` PHP packages (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no  | Docs? | no  | Issues | Fix symfony#2951  | License | MIT  Since symfony#2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages

carsonbot added the Status: Needs Review Needs to be reviewed label Jul 20, 2025

Kocal commented Jul 20, 2025

View reviewed changes

Kocal force-pushed the move-from-yarn-to-pnpm branch 7 times, most recently from 1eef72b to 548ae06 Compare July 21, 2025 06:59

Kocal commented Jul 21, 2025

View reviewed changes

Kocal force-pushed the move-from-yarn-to-pnpm branch from 548ae06 to d25f4cb Compare July 21, 2025 07:07

Replace Yarn Berry by PNPM

17a4bb7

Kocal force-pushed the move-from-yarn-to-pnpm branch from d25f4cb to 17a4bb7 Compare July 21, 2025 08:06

Kocal commented Jul 21, 2025

View reviewed changes

Kocal requested review from kbond and smnandre July 21, 2025 08:21

kbond approved these changes Jul 21, 2025

View reviewed changes

carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 21, 2025

Kocal merged commit b096ecc into symfony:2.x Jul 21, 2025
31 of 33 checks passed

Kocal mentioned this pull request Jul 28, 2025

Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from vendor/ PHP packages #2952

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Replace Yarn Berry by PNPM #2932

Replace Yarn Berry by PNPM #2932

Kocal commented Jul 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 20, 2025 •

edited

Loading

Uh oh!

Kocal Jul 20, 2025

Uh oh!

Kocal Jul 21, 2025

Uh oh!

Kocal Jul 21, 2025 •

edited

Loading

Uh oh!

Kocal Jul 21, 2025

Uh oh!

Kocal Jul 21, 2025

Uh oh!

Kocal Jul 21, 2025 •

edited

Loading

Uh oh!

smnandre commented Jul 21, 2025

Uh oh!

smnandre commented Jul 21, 2025

Uh oh!

Kocal commented Jul 21, 2025 •

edited

Loading

Uh oh!

kbond left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Replace Yarn Berry by PNPM #2932

Replace Yarn Berry by PNPM #2932

Conversation

Kocal commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Packages dist files size difference

Uh oh!

Kocal Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Kocal Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Kocal Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kocal Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Kocal Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Kocal Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smnandre commented Jul 21, 2025

Uh oh!

smnandre commented Jul 21, 2025

Uh oh!

Kocal commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kbond left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kocal commented Jul 20, 2025 •

edited

Loading

github-actions bot commented Jul 20, 2025 •

edited

Loading

Kocal Jul 21, 2025 •

edited

Loading

Kocal Jul 21, 2025 •

edited

Loading

Kocal commented Jul 21, 2025 •

edited

Loading