Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Sep 28, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Yarn 1.x is dead since 4 years now:
image
all new features and bug fixes are done on Yarn Berry:
image

I've adapted our CI, our building and testing scripts.
Updates on src/**/assets/packages.json are simply dependencies alphabetical sorting.
The yarn.lock has been re-generated to the new structure (but locked versions are still the same).

@smnandre
Copy link
Member

Turbo failures seems related.

That appart, perfect !

@Kocal
Copy link
Member Author

Kocal commented Sep 28, 2024

Yeah I was just taking a break :) it should be fine now

EDIT: if the CI wants to run 🥲

@Kocal Kocal merged commit 028a4e6 into symfony:2.x Sep 28, 2024
61 of 62 checks passed
@Kocal Kocal deleted the yarn-berry branch September 28, 2024 16:52
Kocal added a commit that referenced this pull request Jul 21, 2025
This PR was merged into the 2.x branch.

Discussion
----------

Replace Yarn Berry by PNPM

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Docs?         | no <!-- required for new features -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Purely internal, this PR replaces Yarn by PNPM for the following reasons:
- when working on #2222, I tried to use PNPM instead but it was not possible to not install [Swup "dev"-dependencies](#2221), this is now possible
- it is [more efficient and performant](https://pnpm.io/benchmarks), and better for your disk
- it has more [features](https://pnpm.io/feature-comparison), better Workspaces support and [Catalogs](https://pnpm.io/catalogs) 🤩
- commands to release packages on npm are simpler

For developers working on UX, [pnpm can be installed with Corepack](https://pnpm.io/installation#using-corepack)

Note: the ~26k lines changed are mainly about lock files

Commits
-------

17a4bb7 Replace Yarn Berry by PNPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants