Skip to content

Conversation

konomae
Copy link
Contributor

@konomae konomae commented Apr 14, 2025

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

No.

Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: fc94bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 14, 2025

PR packaged and instant preview available.

View demo website

Install locally:

npm i -D https://pkg.pr.new/stylelint@fc94bc2

(View Commit)

@@ -46,9 +45,9 @@ describe('compactFormatter', () => {
},
];

const output = getCleanFormatterOutput(results, compactFormatter);
const output = compactFormatter(results);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if getCleanFormatterOutput is really necessary here. 🤔

@konomae konomae force-pushed the compact-formatter-newline branch from ccf6a9d to fc94bc2 Compare April 14, 2025 15:30
);
});

lines.push('');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

Both the GitHub and TAP formatters have that line before the join.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@jeddy3 jeddy3 mentioned this pull request Apr 22, 2025
6 tasks
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@ybiquitous ybiquitous merged commit 3c0c86c into stylelint:main Apr 23, 2025
17 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 27, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.18.0 | 16.19.1 |


## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25)

-   Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23)

It adds 2 options to 2 rules and fixes 3 bugs.

-   Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)).
-   Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 27, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.18.0 | 16.19.1 |


## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25)

-   Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23)

It adds 2 options to 2 rules and fixes 3 bugs.

-   Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)).
-   Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix compact formatter with pnpm to newline the exit code
4 participants