Skip to content

Conversation

ryo-manba
Copy link
Member

Which issue, if any, is this issue related to?

Closes #8291

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

Copy link

changeset-bot bot commented Mar 22, 2025

🦋 Changeset detected

Latest commit: 8e467a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 22, 2025

PR packaged and instant preview available.

View demo website

Install locally:

npm i -D https://pkg.pr.new/stylelint@8e467a0

(View Commit)

@@ -59,7 +59,7 @@ The following patterns are _not_ considered problems:
@font-palette-values --foo {}
```

## Secondary Options
## Optional secondary options
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the formatting as well. It was my mistake before. 🙇

@ryo-manba ryo-manba marked this pull request as draft March 22, 2025 06:51
@ryo-manba ryo-manba marked this pull request as ready for review March 22, 2025 07:05
@ryo-manba ryo-manba marked this pull request as draft March 23, 2025 14:55
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryo-manba Thank you for working on this!

It's looking great. I've added a suggestion for the option description to match our conventions in the other rule READMEs.

@jeddy3 jeddy3 mentioned this pull request Apr 3, 2025
6 tasks
ryo-manba and others added 2 commits April 8, 2025 00:28
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ryo-manba ryo-manba marked this pull request as ready for review April 7, 2025 15:56
@ryo-manba ryo-manba requested review from jeddy3 and romainmenke April 7, 2025 15:56
@ryo-manba
Copy link
Member Author

@jeddy3 @romainmenke
Sorry for the delay. I've addressed your comment.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

I've requested a couple more tweaks to the docs.

ryo-manba and others added 4 commits April 8, 2025 09:21
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ryo-manba ryo-manba requested a review from jeddy3 April 8, 2025 00:25
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thank you. 👍🏼

I've left a few minor suggestions, so can you have a quick look? Although they're not be a blocker.

ryo-manba and others added 2 commits April 8, 2025 13:45
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@ryo-manba ryo-manba requested a review from ybiquitous April 8, 2025 14:22
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@jeddy3 jeddy3 merged commit 09921ed into main Apr 8, 2025
20 checks passed
@jeddy3 jeddy3 deleted the issue-8291 branch April 8, 2025 14:36
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 27, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.18.0 | 16.19.1 |


## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25)

-   Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23)

It adds 2 options to 2 rules and fixes 3 bugs.

-   Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)).
-   Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 27, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.18.0 | 16.19.1 |


## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25)

-   Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)).


## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23)

It adds 2 options to 2 rules and fixes 3 bugs.

-   Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)).
-   Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)).
-   Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add exceptWithoutPropertyFallback: [] to function-allowed-list
4 participants