-
-
Notifications
You must be signed in to change notification settings - Fork 976
Add exceptWithoutPropertyFallback: []
to function-allowed-list
#8488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8e467a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR packaged and instant preview available. Install locally:
|
@@ -59,7 +59,7 @@ The following patterns are _not_ considered problems: | |||
@font-palette-values --foo {} | |||
``` | |||
|
|||
## Secondary Options | |||
## Optional secondary options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the formatting as well. It was my mistake before. 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryo-manba Thank you for working on this!
It's looking great. I've added a suggestion for the option description to match our conventions in the other rule READMEs.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@jeddy3 @romainmenke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes.
I've requested a couple more tweaks to the docs.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thank you. 👍🏼
I've left a few minor suggestions, so can you have a quick look? Although they're not be a blocker.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.18.0 | 16.19.1 | ## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25) - Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23) It adds 2 options to 2 rules and fixes 3 bugs. - Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)). - Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.18.0 | 16.19.1 | ## [v16.19.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16191---2025-04-25) - Fixed: `no-empty-source` false positives for non-standard syntaxes ([#8548](stylelint/stylelint#8548)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.19.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16190---2025-04-23) It adds 2 options to 2 rules and fixes 3 bugs. - Added: `exceptWithoutPropertyFallback: []` to `function-allowed-list` ([#8488](stylelint/stylelint#8488)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `ignore: ["four-into-three-edge-values"]` to `shorthand-property-no-redundant-values` ([#8527](stylelint/stylelint#8527)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `compact` formatter with pnpm to newline the exit code ([#8534](stylelint/stylelint#8534)) ([@konomae](https://github.com/konomae)). - Fixed: `declaration-property-value-no-unknown` range and message for invalid syntax within known functions ([#8528](stylelint/stylelint#8528)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-empty-source` false positives for `--report-needless-disables` ([#8536](stylelint/stylelint#8536)) ([@romainmenke](https://github.com/romainmenke)).
Closes #8291
No, it's self-explanatory.