feat: remove haste #811
Merged
feat: remove haste #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: run npx.exe on Windows * use npx.cmd
|
Note: I haven't tested this yet, will do later today. For now, I am just sending out a PR for a review. |
|
@thymikee, could you CC somebody from the Metro team on this PR? I want to point out that we always explicitly set "platforms" and "sourceExts" and that Metro doesn't need to explicitly set these platforms here: https://github.com/facebook/metro/blob/master/packages/metro-config/src/defaults/defaults.js#L58 |
|
I wonder how we can debug the Windows failure? |
|
I have rebased this against |
|
Merging since tests are passing and I had former approval of @thymikee |
thymikee
pushed a commit
that referenced
this pull request
Nov 20, 2019
* update lockfile * v3.0.0-alpha.3 * chore: add v3 support table * v3.0.0-alpha.4 * v3.0.0-alpha.5 * chore: set publishConfig for packages * v3.0.0-alpha.6 * fix: check for podspecPath in warnAboutPodInstall (#800) * fix: run npx.cmd on Windows (#801) * fix: run npx.exe on Windows * use npx.cmd * v3.0.0-alpha.7 * fix: podfile parsing on invalid yaml (#810) * Remove haste * Update test without large snapshot * Update configuration * Revert unecessary changes * One more file
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Haste has been removed in 0.61 of React Native and we should remove it too. Otherwise, we are setting
hasteImplPathpointing to a file that has been removed from React Native 0.61 via facebook/react-native@7a2463e