fix: podfile parsing on invalid yaml #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Oct 18, 2019
|
Thank you for the fix and a test <3 |
|
Hi. |
grabbou
added a commit
that referenced
this pull request
Nov 14, 2019
* update lockfile * v3.0.0-alpha.3 * chore: add v3 support table * v3.0.0-alpha.4 * v3.0.0-alpha.5 * chore: set publishConfig for packages * v3.0.0-alpha.6 * fix: check for podspecPath in warnAboutPodInstall (#800) * fix: run npx.cmd on Windows (#801) * fix: run npx.exe on Windows * use npx.cmd * v3.0.0-alpha.7 * fix: podfile parsing on invalid yaml (#810) * Remove haste * Update test without large snapshot * Update configuration * Revert unecessary changes * One more file
thymikee
pushed a commit
that referenced
this pull request
Nov 20, 2019
* update lockfile * v3.0.0-alpha.3 * chore: add v3 support table * v3.0.0-alpha.4 * v3.0.0-alpha.5 * chore: set publishConfig for packages * v3.0.0-alpha.6 * fix: check for podspecPath in warnAboutPodInstall (#800) * fix: run npx.cmd on Windows (#801) * fix: run npx.exe on Windows * use npx.cmd * v3.0.0-alpha.7 * fix: podfile parsing on invalid yaml (#810) * Remove haste * Update test without large snapshot * Update configuration * Revert unecessary changes * One more file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes the issue described at #805 where when
Podfile.lockis an invalid yaml file, thereact-native run ioscommand would fail.To achieve this, I only parse parts of the Podfile we need, which are valid yaml.
Fixes #805
Test Plan:
Unit test insures that error no longer happens and output is correct.