Skip to content

Convert more low-level integration tests into unit tests #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 2, 2025
Merged

Convert more low-level integration tests into unit tests #2473

merged 10 commits into from
Jun 2, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 29, 2025

Previously: #2472, #2462

This concludes the set of tests that #1475 touched.

Then, the size of rustls::internals is minimised, which demonstrates that these changes have allowed (eg) ServerExtension and ClientExtension to become private.

Finally, the CertificateType enum type is added to the public API. This is the sort of issue that the api.rs-level tests are meant to find, but was entangled in the noise of rustls::internal::* use.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 29, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11530424 11580940 50516 (0.44%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9967395 9944626 -22769 (-0.23%) 0.60%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304482 3300010 -4472 (-0.14%) 0.23%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5013130 5008960 -4170 (-0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11575336 11584651 9315 (0.08%) 1.26%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78737924 78687258 -50666 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10463083 10469396 6313 (0.06%) 1.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56578327 56549774 -28553 (-0.05%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299856 4297756 -2100 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78508152 78471923 -36229 (-0.05%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4759194 4757094 -2100 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78453376 78423568 -29808 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3868611 3867171 -1440 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78472806 78443728 -29078 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78722980 78694537 -28443 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55297236 55278125 -19111 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9944866 9948222 3356 (0.03%) 0.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78476848 78501051 24203 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56599919 56582710 -17209 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55219487 55203619 -15868 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55221190 55205452 -15738 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78437050 78417414 -19636 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001200 2001699 499 (0.02%) 1.19%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579768 3580484 716 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55278658 55289539 10881 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55210015 55199233 -10782 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4749310 4750187 877 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56596592 56587233 -9359 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78699403 78686939 -12464 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78656814 78667967 11153 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586208 3586684 476 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907531 2907162 -369 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235450 58229016 -6434 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58123154 58117362 -5792 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58130365 58124574 -5791 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154755 58148971 -5784 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58257401 58251609 -5792 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232573 58226792 -5781 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876781 3877141 360 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56573295 56568059 -5236 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218876 4219236 360 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78707601 78713610 6009 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904506 2904287 -219 (-0.01%) 0.84%
handshake_session_id_ring_1.2_rsa_aes_client 4307320 4307020 -300 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4570938 4570638 -300 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699460 92693661 -5799 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691085 92685288 -5797 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659489 92653699 -5790 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92723321 92717528 -5793 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668613 92662826 -5787 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697217 92691434 -5783 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78708612 78703720 -4892 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748153 4747868 -285 (-0.01%) 0.93%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991775 31990005 -1770 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113425 32111655 -1770 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988590 31986850 -1740 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991642 31989902 -1740 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32110240 32108500 -1740 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32113292 32111552 -1740 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56545610 56548530 2920 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003566 2003472 -94 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550963 32552238 1275 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553772 32555047 1275 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32449053 32450283 1230 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451820 32453050 1230 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451862 32453092 1230 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553730 32554960 1230 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035426 58037314 1888 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30836399 30835585 -814 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30927689 30926875 -814 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30839324 30838514 -810 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30843378 30842568 -810 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31154675 31153859 -816 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30930614 30929804 -810 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30934668 30933858 -810 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31225925 31225109 -816 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31158008 31157198 -810 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31161996 31161186 -810 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31229279 31228469 -810 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31233267 31232457 -810 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296462 1296444 -18 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157334 58157950 616 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305683 3305650 -33 (-0.00%) 0.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719926 1719939 13 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999872 10999802 -70 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55294868 55295218 350 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246505 2246493 -12 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56598791 56599092 301 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295267 1295262 -5 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78526936 78527098 162 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222937 7222930 -7 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334262 2334260 -2 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339911 2339909 -2 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736305 34736326 21 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220985 7220981 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127928 11127923 -5 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133689 11133684 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632584 80632574 -10 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738006 34738010 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452700 46452696 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533873 80533869 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643606 80643603 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538688 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284262 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294219 46294220 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397767 46397768 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637660 80637661 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459282 46459282 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448258 46448258 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189285 46189285 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289082 46289082 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543179 80543179 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.28 ms 1.30 ms ⚠️ 0.02 ms (1.69%) 1.13%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.26 ms 11.41 ms ⚠️ 0.15 ms (1.33%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.42 ms 10.55 ms ⚠️ 0.13 ms (1.23%) 1.18%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.08 ms 11.21 ms ⚠️ 0.13 ms (1.22%) 1.15%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.30 ms 11.44 ms ⚠️ 0.14 ms (1.22%) 1.18%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.13 ms 11.26 ms ⚠️ 0.13 ms (1.18%) 1.14%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.29 ms 11.42 ms ⚠️ 0.13 ms (1.13%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.28 ms 1.30 ms 0.02 ms (1.54%) 1.85%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.06 ms 0.01 ms (1.36%) 1.77%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.61 ms 10.75 ms 0.13 ms (1.27%) 1.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.65 ms 10.78 ms 0.13 ms (1.19%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.47 ms 10.59 ms 0.12 ms (1.14%) 1.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.09 ms 11.21 ms 0.12 ms (1.11%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.16 ms 11.28 ms 0.12 ms (1.04%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.35 ms 11.46 ms 0.11 ms (1.00%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 646.56 µs 651.31 µs 4.75 µs (0.73%) 3.79%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 645.88 µs 650.25 µs 4.37 µs (0.68%) 4.01%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.05 ms 5.07 ms 0.02 ms (0.49%) 5.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.32 ms 1.33 ms 0.01 ms (0.47%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.33 ms 1.34 ms 0.01 ms (0.46%) 1.58%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.50 ms 5.48 ms -0.02 ms (-0.43%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.52 ms -0.02 ms (-0.39%) 1.29%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.79 ms 0.01 ms (0.38%) 3.02%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 5.97 ms -0.02 ms (-0.37%) 1.09%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.32%) 1.05%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.69 ms 4.68 ms -0.01 ms (-0.31%) 6.74%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.57 ms 5.55 ms -0.02 ms (-0.30%) 1.37%
handshake_session_id_ring_1.3_rsa_aes 6.04 ms 6.02 ms -0.02 ms (-0.28%) 1.06%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.28%) 1.60%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.04 ms -0.02 ms (-0.27%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms 0.00 ms (0.26%) 2.08%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.60 ms 8.58 ms -0.02 ms (-0.25%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.38 ms 5.37 ms -0.01 ms (-0.24%) 5.95%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.59 ms -0.01 ms (-0.23%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.77 ms 13.80 ms 0.03 ms (0.22%) 2.12%
handshake_no_resume_ring_1.2_rsa_aes 949.53 µs 951.58 µs 2.04 µs (0.22%) 1.25%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.37 ms 5.38 ms 0.01 ms (0.21%) 5.78%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.61 ms -0.02 ms (-0.19%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 952.91 µs 954.54 µs 1.63 µs (0.17%) 1.33%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.69 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.08 ms -0.01 ms (-0.16%) 1.04%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.66 ms 8.65 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 464.41 µs 463.89 µs -0.52 µs (-0.11%) 2.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.82 ms 13.83 ms 0.01 ms (0.08%) 2.34%
handshake_no_resume_ring_1.3_ecdsap256_chacha 461.93 µs 461.58 µs -0.35 µs (-0.08%) 3.01%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.00 ms (0.05%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.94 ms 0.01 ms (0.04%) 2.20%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.47 ms 8.48 ms 0.00 ms (0.04%) 3.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.13 ms 13.14 ms 0.01 ms (0.04%) 2.32%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.43 ms 0.01 ms (0.04%) 2.34%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.33 ms 5.33 ms -0.00 ms (-0.03%) 6.13%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.03 ms -0.00 ms (-0.02%) 1.75%
transfer_no_resume_ring_1.2_rsa_aes 5.81 ms 5.81 ms 0.00 ms (0.01%) 5.29%
transfer_no_resume_ring_1.3_rsa_aes 5.86 ms 5.86 ms -0.00 ms (-0.01%) 5.56%
handshake_no_resume_ring_1.3_rsa_aes 954.40 µs 954.45 µs 0.05 µs (0.01%) 1.60%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz force-pushed the jbp-internalise-tests-2 branch from a9d59cb to d72a7f6 Compare May 29, 2025 11:39
@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.77578% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (ca468df) to head (02637e9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/server/test.rs 99.40% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2473      +/-   ##
==========================================
+ Coverage   95.33%   95.43%   +0.10%     
==========================================
  Files          97       97              
  Lines       21504    21959     +455     
==========================================
+ Hits        20500    20956     +456     
+ Misses       1004     1003       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz force-pushed the jbp-internalise-tests-2 branch 2 times, most recently from 207e19e to cfaead5 Compare May 29, 2025 13:35
@ctz ctz marked this pull request as ready for review May 29, 2025 13:56
djc
djc approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice!

ctz added 10 commits June 2, 2025 09:32
@ctz
Convert server_picks_ffdhe_group_when_clienthello_(...) into unit test
eb5dbf8
@ctz
Convert server_picks_ffdhe_group_when_(...) into unit test
41a3b8c
@ctz
Convert server_accepts_client_with_no_ecpoints(..) into unit test
9a4b1a7
@ctz
Convert cas_extension_in_client_hello_if_(...) to unit test
711e463
@ctz
Convert test_raw_keys::alter_client_hello into unit tests
203eecc
@ctz
Convert test_raw_keys::incorrectly_alter_server_hello into unit tests
71cdac8
@ctz
Convert `test_client_with_custom_verifier_can_accept_ecdsa_sha1_signa…
efa5c65 
…tures` to unit test
@ctz
tests/api: minor clean-up of ProtocolVersion enum use
ed67167
@ctz
Withdraw unnecessary types from rustls::internals
d76f610
@ctz
Promote CertificateType enum to public API
02637e9 
Since 9944795 this has appeared in the public API, in the return types
of `server::ClientHello::server_cert_types()` and
`server::ClientHello::client_cert_types()`.

Move its definition into `crate::enums`.
@ctz ctz force-pushed the jbp-internalise-tests-2 branch from cfaead5 to 02637e9 Compare June 2, 2025 08:47
@ctz ctz added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit 2e7f326 Jun 2, 2025
34 checks passed
@ctz ctz deleted the jbp-internalise-tests-2 branch June 2, 2025 09:08
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc