Skip to content

Convert more low-level integration tests into unit tests #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2025
Merged

Convert more low-level integration tests into unit tests #2472

merged 8 commits into from
May 27, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 26, 2025

This continues work from #2462. Still not done, but baby steps...

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9949231 9987682 38451 (0.39%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11577547 11555932 -21615 (-0.19%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4747239 4751500 4261 (0.09%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9969442 9961089 -8353 (-0.08%) 0.63%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10444294 10435817 -8477 (-0.08%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78493021 78546337 53316 (0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304346 3302154 -2192 (-0.07%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305594 3303506 -2088 (-0.06%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55289179 55315751 26572 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003198 2004022 824 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78537452 78506810 -30642 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11591716 11587364 -4352 (-0.04%) 1.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580630 3579286 -1344 (-0.04%) 1.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78435129 78462911 27782 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78693439 78670942 -22497 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55303971 55288614 -15357 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55214839 55228669 13830 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78694022 78675204 -18818 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907245 2907939 694 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78676235 78692425 16190 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56566637 56555278 -11359 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78721924 78737218 15294 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78495444 78508906 13462 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56558649 56549228 -9421 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78441691 78429163 -12528 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56559621 56567745 8124 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56608731 56616278 7547 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78719581 78729330 9749 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55293531 55300129 6598 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55214879 55208565 -6314 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56599098 56605516 6418 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748646 4749172 526 (0.01%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55203169 55199591 -3578 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78433316 78428483 -4833 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78717836 78722154 4318 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001187 2001286 99 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56608098 56610345 2247 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904426 2904511 85 (0.00%) 0.79%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586118 3586019 -99 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229661 58229015 -646 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296426 1296416 -10 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719923 1719927 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295244 1295242 -2 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222930 7222922 -8 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738052 34738027 -25 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284272 46284262 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452707 46452700 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637665 80637655 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643605 80643596 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189291 46189296 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533863 80533871 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538682 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653698 92653689 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685290 92685298 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289085 46289088 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693665 92693659 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448259 46448256 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459281 46459278 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251613 58251610 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691425 92691429 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035394 58035392 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226789 58226787 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662827 92662830 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543187 80543189 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632583 80632585 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294220 46294221 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117365 58117364 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717521 92717522 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550648 32550648 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113065 32113065 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553457 32553457 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109880 32109880 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220961 7220961 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988230 31988230 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133666 11133666 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448693 32448693 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553370 32553370 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451460 32451460 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112932 32112932 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876271 3876271 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124576 58124576 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246478 2246478 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991415 31991415 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218366 4218366 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397765 46397765 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127905 11127905 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451502 32451502 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157301 58157301 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306090 4306090 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148972 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736331 34736331 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991282 31991282 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.76 ms 4.69 ms -0.07 ms (-1.57%) 5.35%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.16 ms 5.09 ms -0.07 ms (-1.41%) 4.83%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.43 ms 5.36 ms -0.07 ms (-1.36%) 4.20%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.45 ms 5.38 ms -0.07 ms (-1.27%) 4.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.45 ms 5.38 ms -0.07 ms (-1.26%) 4.28%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.82 ms -0.07 ms (-1.21%) 4.60%
transfer_no_resume_ring_1.3_rsa_aes 5.94 ms 5.87 ms -0.07 ms (-1.20%) 4.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 657.70 µs 651.97 µs -5.73 µs (-0.87%) 4.38%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.55 ms 8.48 ms -0.07 ms (-0.82%) 2.38%
handshake_no_resume_ring_1.3_ecdsap256_chacha 464.83 µs 461.50 µs -3.33 µs (-0.72%) 3.73%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 656.77 µs 652.15 µs -4.62 µs (-0.70%) 4.13%
handshake_no_resume_ring_1.3_ecdsap256_aes 466.62 µs 463.38 µs -3.24 µs (-0.69%) 4.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.47 ms 11.41 ms -0.07 ms (-0.58%) 1.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.22 ms 13.15 ms -0.08 ms (-0.57%) 1.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.54 ms -0.06 ms (-0.56%) 1.24%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 12.94 ms -0.07 ms (-0.55%) 1.79%
transfer_no_resume_ring_1.3_rsa_chacha 13.50 ms 13.43 ms -0.07 ms (-0.55%) 1.83%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.90 ms 13.82 ms -0.07 ms (-0.54%) 1.69%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.80 ms 10.74 ms -0.06 ms (-0.54%) 1.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.83 ms 10.77 ms -0.06 ms (-0.53%) 1.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.90 ms 13.83 ms -0.07 ms (-0.53%) 1.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.21 ms -0.06 ms (-0.52%) 1.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.52 ms 11.46 ms -0.06 ms (-0.50%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.48 ms 11.43 ms -0.05 ms (-0.48%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.32 ms -0.01 ms (-0.47%) 1.85%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.04 ms -0.08 ms (-0.47%) 1.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.58 ms -0.05 ms (-0.47%) 1.38%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.29 ms 11.24 ms -0.05 ms (-0.46%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.45%) 1.64%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.51 ms 11.46 ms -0.05 ms (-0.45%) 1.03%
handshake_no_resume_ring_1.2_rsa_aes 954.27 µs 950.05 µs -4.22 µs (-0.44%) 1.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.26 ms -0.05 ms (-0.44%) 1.19%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms -0.01 ms (-0.44%) 2.39%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.33 ms 11.28 ms -0.05 ms (-0.42%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms -0.01 ms (-0.38%) 1.56%
handshake_no_resume_ring_1.3_rsa_chacha 956.37 µs 953.03 µs -3.35 µs (-0.35%) 1.68%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms -0.00 ms (-0.30%) 3.38%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.00 ms (-0.29%) 2.18%
handshake_no_resume_ring_1.3_rsa_aes 956.95 µs 954.26 µs -2.69 µs (-0.28%) 1.48%
handshake_session_id_ring_1.3_rsa_aes 6.02 ms 6.01 ms -0.02 ms (-0.26%) 1.39%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.26%) 1.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms -0.00 ms (-0.24%) 1.60%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms -0.00 ms (-0.22%) 3.40%
handshake_tickets_ring_1.3_ecdsap256_aes 5.59 ms 5.58 ms -0.01 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.61 ms -0.02 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.55 ms 5.54 ms -0.01 ms (-0.20%) 1.27%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.01 ms (-0.20%) 1.09%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.65 ms 8.64 ms -0.02 ms (-0.19%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.04 ms 6.03 ms -0.01 ms (-0.19%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.08 ms 6.07 ms -0.01 ms (-0.17%) 1.17%
handshake_tickets_ring_1.3_ecdsap384_aes 8.69 ms 8.67 ms -0.01 ms (-0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.59 ms 8.58 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.53 ms 5.52 ms -0.01 ms (-0.15%) 1.45%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.57 ms 3.56 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.50 ms 5.49 ms -0.01 ms (-0.12%) 1.01%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.56 ms -0.00 ms (-0.10%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz force-pushed the jbp-internalise-tests branch from d2cda85 to 1682a0c Compare May 26, 2025 15:45
@ctz ctz marked this pull request as draft May 26, 2025 15:53
@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.33%. Comparing base (75f94f0) to head (3e28938).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/client/test.rs 99.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
+ Coverage   95.30%   95.33%   +0.02%     
==========================================
  Files          97       97              
  Lines       21359    21506     +147     
==========================================
+ Hits        20356    20502     +146     
- Misses       1003     1004       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz force-pushed the jbp-internalise-tests branch from 1682a0c to 9922c36 Compare May 27, 2025 06:55
@ctz ctz marked this pull request as ready for review May 27, 2025 07:14
@ctz ctz requested a review from djc May 27, 2025 07:17
djc
djc approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice, how are you feeling about this effort? Worth it?

@ctz ctz force-pushed the jbp-internalise-tests branch from 762ba94 to 26645c9 Compare May 27, 2025 15:08
@ctz ctz force-pushed the jbp-internalise-tests branch from 26645c9 to 3e28938 Compare May 27, 2025 15:21
@ctz
Copy link
Member Author

ctz commented May 27, 2025

Seems nice, how are you feeling about this effort? Worth it?

Yes I think so. My main goal remains landing #1475, so I am working towards the integration tests in the way of doing that.

@ctz
Copy link
Member Author

ctz commented May 27, 2025

(test-only code, merging with one approval)

@ctz ctz added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 70d00af May 27, 2025
34 checks passed
@ctz ctz deleted the jbp-internalise-tests branch May 27, 2025 15:55
@ctz ctz mentioned this pull request May 29, 2025
Merged
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc