Skip to content

Move some tests about; reduce duplication of test helper code #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 21, 2025
Merged

Move some tests about; reduce duplication of test helper code #2462

merged 14 commits into from
May 21, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 19, 2025

This PR is doing a couple of things:

  1. moving some "integration" tests from tests/api.rs into the crate; there much more to do here.
  2. refactoring tests/common/mod.rs so it no longer picks up a CryptoProvider by magic.
  3. splitting out tests/common/mod.rs into its own internal crate.
  4. using that crate to remove the various duplicated copies we had of that code.

The goal of (3) was to make (1) easier, but unfortunately it won't help. But I think this is a general improvement.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 19, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910405 2904175 ✅ -6230 (-0.21%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913481 2907625 ✅ -5856 (-0.20%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9984663 9927328 -57335 (-0.57%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9970229 9925039 -45190 (-0.45%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11580820 11542930 -37890 (-0.33%) 1.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11573371 11557677 -15694 (-0.14%) 1.62%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10460212 10446334 -13878 (-0.13%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4743684 4748774 5090 (0.11%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229084 7222914 -6170 (-0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227114 7220952 -6162 (-0.09%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78495062 78428854 -66208 (-0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78734786 78677469 -57317 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303551 3305535 1984 (0.06%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55238523 55205730 -32793 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56585995 56557140 -28855 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78462941 78425146 -37795 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78478934 78515453 36519 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580621 3579321 -1300 (-0.04%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55225863 55206736 -19127 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586381 3587603 1222 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55282269 55300262 17993 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78500586 78478121 -22465 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78685620 78664856 -20764 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78470661 78451438 -19223 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78723201 78704690 -18511 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001078 2001519 441 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55289870 55278507 -11363 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296666 1296408 -258 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295484 1295234 -250 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56560035 56549305 -10730 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55218161 55208195 -9966 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78711065 78724975 13910 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34744033 34738019 -6014 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742279 34736291 -5988 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56607819 56598311 -9508 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78725074 78737799 12725 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750692 4750039 -653 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56600441 56606977 6536 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56598865 56605256 6391 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719748 1719936 188 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246303 2246487 184 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334062 2334246 184 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339711 2339895 184 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78508381 78514071 5690 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56560050 56556212 -3838 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78700242 78695093 -5149 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298386 242 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003785 2003675 -110 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012380 246 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461251 46459281 -1970 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450209 46448254 -1955 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291017 46289091 -1926 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304366 3304259 -107 (-0.00%) 0.24%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545413 80543180 -2233 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645571 80643604 -1967 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634522 80632583 -1939 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540614 80538686 -1928 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55286879 55287917 1038 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691975 92693661 1686 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227968 58229015 1047 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306434 4306360 -74 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128086 11127897 -189 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133847 11133658 -189 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000039 10999871 -168 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448453 319 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550408 319 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31991042 298 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112692 298 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31991175 232 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112825 232 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294534 46294234 -300 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987990 207 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109640 207 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30834925 -126 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926215 -126 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451220 82 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451262 82 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553130 82 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553217 82 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841908 -66 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933198 -66 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153199 -66 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156538 66 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224449 -66 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227809 66 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837854 58 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929144 58 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867861 6 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876537 3876541 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218640 4218636 -4 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757724 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189316 46189285 -31 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284289 46284262 -27 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533889 80533867 -22 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397779 46397769 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691418 92691436 18 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452707 46452698 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124575 58124584 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226791 58226782 -9 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160526 4 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231797 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157305 58157302 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717532 92717534 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035395 58035394 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251609 58251608 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685299 92685298 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637666 80637666 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653698 92653698 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662821 92662821 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117363 58117363 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148972 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_aes 480.44 µs 462.00 µs ✅ -18.44 µs (-3.84%) 3.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha 477.87 µs 459.73 µs ✅ -18.14 µs (-3.80%) 3.33%
handshake_no_resume_ring_1.3_rsa_chacha 969.21 µs 951.99 µs ✅ -17.23 µs (-1.78%) 1.38%
handshake_no_resume_ring_1.2_rsa_aes 964.77 µs 949.30 µs ✅ -15.48 µs (-1.60%) 1.27%
handshake_no_resume_ring_1.3_rsa_aes 967.68 µs 952.62 µs ✅ -15.06 µs (-1.56%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.33 ms ✅ -0.02 ms (-1.51%) 1.39%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 668.53 µs 648.95 µs -19.59 µs (-2.93%) 4.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 668.09 µs 649.60 µs -18.49 µs (-2.77%) 4.37%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.74 ms 4.64 ms -0.10 ms (-2.01%) 5.65%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.41 ms 5.31 ms -0.11 ms (-1.95%) 5.32%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.43 ms 5.33 ms -0.10 ms (-1.90%) 5.02%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.43 ms 5.33 ms -0.10 ms (-1.85%) 4.79%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.04 ms -0.09 ms (-1.80%) 6.20%
transfer_no_resume_ring_1.3_rsa_aes 5.92 ms 5.82 ms -0.10 ms (-1.70%) 4.58%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.08 ms -0.02 ms (-1.61%) 3.61%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.34 ms 1.32 ms -0.02 ms (-1.59%) 2.91%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.33 ms -0.02 ms (-1.39%) 1.46%
transfer_no_resume_ring_1.2_rsa_aes 5.86 ms 5.78 ms -0.08 ms (-1.33%) 5.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.33 ms 1.32 ms -0.02 ms (-1.17%) 2.82%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.53 ms 8.43 ms -0.10 ms (-1.12%) 2.85%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.22 ms 13.10 ms -0.12 ms (-0.90%) 1.75%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.89 ms 13.77 ms -0.12 ms (-0.86%) 2.12%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.89 ms 13.79 ms -0.10 ms (-0.76%) 1.74%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.90 ms -0.10 ms (-0.74%) 1.96%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.50 ms -0.01 ms (-0.73%) 2.46%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.07 ms -0.04 ms (-0.72%) 1.17%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.39 ms -0.09 ms (-0.67%) 2.07%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.63%) 1.40%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.59 ms -0.03 ms (-0.60%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.56 ms -0.03 ms (-0.60%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.56 ms -0.02 ms (-0.59%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.09 ms 16.00 ms -0.09 ms (-0.59%) 1.46%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.56 ms -0.02 ms (-0.57%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.52 ms -0.03 ms (-0.50%) 1.45%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.02 ms -0.03 ms (-0.48%) 1.35%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.05 ms -0.03 ms (-0.43%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.48 ms 11.43 ms -0.05 ms (-0.40%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.80 ms 10.75 ms -0.04 ms (-0.40%) 1.75%
handshake_tickets_ring_1.3_ecdsap384_aes 8.71 ms 8.68 ms -0.03 ms (-0.38%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.59 ms -0.04 ms (-0.38%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.56 ms -0.04 ms (-0.38%) 1.54%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.29 ms 11.25 ms -0.04 ms (-0.37%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.23 ms -0.04 ms (-0.36%) 1.69%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.49 ms -0.02 ms (-0.35%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.42 ms -0.04 ms (-0.34%) 1.44%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.49 ms 11.45 ms -0.04 ms (-0.33%) 1.39%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.65 ms -0.03 ms (-0.33%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.27 ms -0.04 ms (-0.33%) 1.28%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.32 ms 11.28 ms -0.04 ms (-0.31%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.50 ms 11.47 ms -0.04 ms (-0.31%) 1.53%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 5.98 ms -0.02 ms (-0.29%) 1.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.81 ms 10.78 ms -0.03 ms (-0.28%) 1.44%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.65 ms 0.00 ms (0.27%) 3.33%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.62 ms -0.02 ms (-0.20%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.60 ms 8.59 ms -0.02 ms (-0.18%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms -0.00 ms (-0.05%) 4.45%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.05660% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (e9335c8) to head (1d1a1d5).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/client/test.rs 96.77% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2462    +/-   ##
========================================
  Coverage   95.26%   95.27%            
========================================
  Files          95       97     +2     
  Lines       21251    21357   +106     
========================================
+ Hits        20245    20348   +103     
- Misses       1006     1009     +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from jbp-nightly-clippy to main May 20, 2025 11:53
djc
djc approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty good direction at least!

@ctz ctz force-pushed the ci/jbp-internal-tests branch from 9f70557 to 9dc5d32 Compare May 21, 2025 08:19
@ctz ctz force-pushed the ci/jbp-internal-tests branch from 9dc5d32 to 5ab7ce0 Compare May 21, 2025 08:51
ctz added 3 commits May 21, 2025 10:11
@ctz ctz force-pushed the ci/jbp-internal-tests branch from 5ab7ce0 to 1d1a1d5 Compare May 21, 2025 09:11
@ctz
Copy link
Member Author

ctz commented May 21, 2025

merging with one review: test-only code

@ctz ctz added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 34fb672 May 21, 2025
64 checks passed
@ctz ctz deleted the ci/jbp-internal-tests branch May 21, 2025 09:37
This was referenced May 26, 2025
Merged
Merged
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc