[compiletest-related cleanups 1/7] Cleanup is_rustdoc logic and remove a useless path join in rustdoc-json runtest logic
#136441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
compiletest-related cleanups 1/9] cleanup is_rustdoc logiccompiletest-related cleanups 1/9] Cleanup is_rustdoc logic
compiletest-related cleanups 1/9] Cleanup is_rustdoc logiccompiletest-related cleanups 1/8] Cleanup is_rustdoc logic
compiletest-related cleanups 1/8] Cleanup is_rustdoc logiccompiletest-related cleanups 1/7] Cleanup is_rustdoc logic and remove a useless path join in rustdoc-json runtest logic
jieyouxu
commented
Feb 2, 2025
Comment on lines
-25
to
+24
| .arg(root.join(&out_dir)) | ||
| .arg(&out_dir) |
There was a problem hiding this comment.
This currently is useless because out_dir is an absolute path, so root.join(&out_dir) will just become out_dir. This would be actually wrong if out_dir was a relative path, because build dir is not necessarily under source root (such as in CI).
|
@rustbot ready |
compiler-errors
approved these changes
Feb 2, 2025
|
r? compiler-errors @bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#136356 (Docs for f16 and f128: correct a typo and add details) - rust-lang#136404 (Remove a footgun-y feature / relic of the past from the compiletest DSL) - rust-lang#136432 (LTA: Actually check where-clauses for well-formedness at the def site) - rust-lang#136438 (miri: improve error when offset_from preconditions are violated) - rust-lang#136441 ([`compiletest`-related cleanups 1/7] Cleanup `is_rustdoc` logic and remove a useless path join in rustdoc-json runtest logic) - rust-lang#136455 (Remove some `Clone` bounds and derives.) - rust-lang#136464 (Remove hook calling via `TyCtxtAt`.) - rust-lang#136467 (override default config profile on tarballs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Rollup merge of rust-lang#136441 - jieyouxu:cleanup-is-rustdoc, r=compiler-errors [`compiletest`-related cleanups 1/7] Cleanup `is_rustdoc` logic and remove a useless path join in rustdoc-json runtest logic Reference for overall changes: rust-lang#136437 Part **1** of **7** of the *`compiletest`-related cleanups* PR series. ### Summary - Don't match on path when we already have test suite names. - Remove a useless path join. r? bootstrap (or compiler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference for overall changes: #136437
Part 1 of 7 of the
compiletest-related cleanups PR series.Summary
r? bootstrap (or compiler)