Skip to content

Conversation

pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Jan 31, 2025

CC: #116909; corrects and expands #124750.

@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 31, 2025
@tgross35
Copy link
Contributor

tgross35 commented Feb 1, 2025

r? tgross35

@rustbot rustbot assigned tgross35 and unassigned scottmcm Feb 1, 2025
@tgross35
Copy link
Contributor

tgross35 commented Feb 1, 2025

Fixes #116909;

This would be an amazingly small PR to fix the ~20 remaining checkboxes on a tracking issue :)

(use Cc to mention without closing)

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a squash

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2025
@pthariensflame
Copy link
Contributor Author

@tgross35 Should be ready!

@tgross35
Copy link
Contributor

tgross35 commented Feb 3, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 3, 2025

📌 Commit baa1cdd has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#136356 (Docs for f16 and f128: correct a typo and add details)
 - rust-lang#136404 (Remove a footgun-y feature / relic of the past from the compiletest DSL)
 - rust-lang#136432 (LTA: Actually check where-clauses for well-formedness at the def site)
 - rust-lang#136438 (miri: improve error when offset_from preconditions are violated)
 - rust-lang#136441 ([`compiletest`-related cleanups 1/7] Cleanup `is_rustdoc` logic and remove a useless path join in rustdoc-json runtest logic)
 - rust-lang#136455 (Remove some `Clone` bounds and derives.)
 - rust-lang#136464 (Remove hook calling via `TyCtxtAt`.)
 - rust-lang#136467 (override default config profile on tarballs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7be7f3b into rust-lang:master Feb 3, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 3, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
Rollup merge of rust-lang#136356 - pthariensflame:patch-1, r=tgross35

Docs for f16 and f128: correct a typo and add details

CC: rust-lang#116909; corrects and expands rust-lang#124750.
@pthariensflame pthariensflame deleted the patch-1 branch February 3, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants