Skip to content

Conversation

JojiiOfficial
Copy link
Contributor

@JojiiOfficial JojiiOfficial commented Aug 21, 2025

Prerequisite for #7047

Migrates to the new shard key format (#5838 and #6209) when loading a collection.

Todo

  • Implementation
  • Tests
  • Remove migration logic once all keys have been migrated

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Extensively tested it and it behaves like I expect. Thanks.

I've added one debug line at the moment we migrate.

@timvisee timvisee merged commit 4012ea9 into dev Aug 22, 2025
16 checks passed
@timvisee timvisee deleted the mirgate_shard_key_on_load branch August 22, 2025 08:47
timvisee added a commit that referenced this pull request Aug 26, 2025
* Migrate shard-key format

* Reduce visibility of was_old_format attribute

* Add debug message when we migrate persisted shard key format

---------

Co-authored-by: timvisee <tim@visee.me>
@timvisee timvisee mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants