Fix broken shard key mapping in consensus snapshot #6209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
Mar 20, 2025
This was referenced Mar 20, 2025
9 tasks
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Use safe shard key wrapper type in consensus snapshot state * Add shard ID iterator * Produce net wrapped shard key mapping type directly * Add useful comments * Fix typo
9 tasks
Merged
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix similar to #5838, but for shard key mappings in the consensus snapshot.
Our consensus snapshot also serializes shard key mappings in an unstable way. It may cause the data to be parsed differently during deserialization.
This PR fixes the problem with a wrapper type. It is used as compatibility layer because we still need to support older versions as well. Eventually we'll fully move to the new type to totally eliminate this problem.
Please see #5838 for more details.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?