Skip to content

Conversation

timvisee
Copy link
Member

Simple extension to #6032.

Also ignore hidden segments when recovering them from a shard snapshot.

This is not strictly necessary. But I felt it's nice to keep both (loading segments, and recovering segments) in sync.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee requested review from agourlay and coszio February 26, 2025 13:28
@timvisee timvisee merged commit 2a2ccda into dev Feb 27, 2025
17 checks passed
@timvisee timvisee deleted the segment-snapshot-restore-ignore-hidden branch February 27, 2025 10:00
timvisee added a commit that referenced this pull request Mar 21, 2025
* Ignore hidden files while restoring shard segments from snapshot

* Remove obsolete into_iter
@timvisee timvisee mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants