Improve segment loading, don't load invalid segments #6032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6025
When loading a local shard, only load segments from valid directory paths.
Before, we'd try to load every entry in the segments directory as if it was a segment. This caused a panic during segment loading if macOS places a
.DS_Store
file in there.More specifically, we now ignore:
.
.DS_Store
We now also walk over all segment path entries before trying to load them. That is significant because we now catch any IO errors before spawning threads. Before we would leak threads if crashing in the middle.
Log example when trying to load such invalid segment:
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?