fix(config): respect GOGC environment variable if no "runtime" block exists #16558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @machine424 since you've been working in this area recently 🙂 |
|
thanks, let's merge #15238 first and you can uncomment the two cases. |
|
the PR was merged by the way |
…exists Fixes: prometheus#16334 Related to: - prometheus#15238 - prometheus#16052 Currently, when the GOGC environment variable is set -- and no `runtime` block is set in the Prometheus config file -- it is ignored and the default value of 75% is always used. However, if there is an empty runtime block (e.g. `runtime: {}`), _then_ the GOGC environment variable is checked. This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the `gogc` field is set in the `runtime` block of the loaded config file, in which case it still gives that precedence). Co-authored-by: Adam Rambo <arambo@protonmail.com> Signed-off-by: Will Hegedus <whegedus@akamai.com>
Signed-off-by: Will Hegedus <whegedus@akamai.com>
|
@machine424 I've rebased and enabled those new tests from your PR. Let me know if there's anything else that's needed! |
|
Looking for release 🙏🏼. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16334
Related to:
Currently, when the GOGC environment variable is set -- and no
runtimeblock is set in the Prometheus config file -- it is ignored and the default value of 75% is always used.However, if there is an empty runtime block (e.g.
runtime: {}), then the GOGC environment variable is checked.This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the
gogcfield is set in theruntimeblock of the loaded config file, in which case it still gives that precedence).