test(cmd): add test for GOGC setting #15238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SuperQ |
machine424
commented
Oct 29, 2024
|
some cases are failing on windows I'll take a look |
machine424
commented
Apr 10, 2025
a260a90 to
8b0e413
Compare
|
cc @SuperQ when you have some time. |
|
test failure is due to #16473 |
wbh1
added a commit
to wbh1/prometheus
that referenced
this pull request
May 5, 2025
…exists Fixes: prometheus#16334 Related to: - prometheus#15238 - prometheus#16052 Currently, when the GOGC environment variable is set -- and no `runtime` block is set in the Prometheus config file -- it is ignored and the default value of 75% is always used. However, if there is an empty runtime block (e.g. `runtime: {}`), _then_ the GOGC environment variable is checked. This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the `gogc` field is set in the `runtime` block of the loaded config file, in which case it still gives that precedence). Co-authored-by: Adam Rambo <arambo@protonmail.com> Signed-off-by: Will Hegedus <whegedus@akamai.com>
df4d44a to
23be5ec
Compare
As suggested in prometheus#14176 (comment) Signed-off-by: machine424 <ayoubmrini424@gmail.com>
bboreham
approved these changes
May 6, 2025
Comment on lines
+752
to
+759
| // Wait for the /metrics endpoint to be ready. | ||
| require.Eventually(t, func() bool { | ||
| r, err = http.Get(fmt.Sprintf("http://127.0.0.1:%d/metrics", port)) | ||
| if err != nil { | ||
| return false | ||
| } | ||
| return r.StatusCode == http.StatusOK | ||
| }, 5*time.Second, 50*time.Millisecond) |
There was a problem hiding this comment.
Alternatively, look at Go's internal metric /gc/gogc:percent.
There was a problem hiding this comment.
how can we get that from a running process?
(the prom metric is based on /gc/gogc:percent)
There was a problem hiding this comment.
(I wanted to run it as a "blackbox" becaue it's simple and because of the gogc logic in main.go itself)
wbh1
added a commit
to wbh1/prometheus
that referenced
this pull request
May 12, 2025
…exists Fixes: prometheus#16334 Related to: - prometheus#15238 - prometheus#16052 Currently, when the GOGC environment variable is set -- and no `runtime` block is set in the Prometheus config file -- it is ignored and the default value of 75% is always used. However, if there is an empty runtime block (e.g. `runtime: {}`), _then_ the GOGC environment variable is checked. This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the `gogc` field is set in the `runtime` block of the loaded config file, in which case it still gives that precedence). Co-authored-by: Adam Rambo <arambo@protonmail.com> Signed-off-by: Will Hegedus <whegedus@akamai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #14176 (comment)