Skip to content

Conversation

mateuszkwiecinski
Copy link
Contributor

@mateuszkwiecinski mateuszkwiecinski commented Jul 10, 2025

Description

The #3049 contained commits which I pushed to my fork to test how the build behaves on windows. These can be safely removed now.

Moreover, after #3035, the build-logic project uses latest kotlin version which supports Java 24, making the extra workaround unnecessary

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review July 10, 2025 06:31
@mateuszkwiecinski mateuszkwiecinski force-pushed the mateuszkwiecinski/cleanup_java_24_bump branch from 9791b1b to 66e2762 Compare July 12, 2025 10:17
@paul-dingemans paul-dingemans merged commit 690d5fc into pinterest:master Jul 12, 2025
12 checks passed
@mateuszkwiecinski mateuszkwiecinski deleted the mateuszkwiecinski/cleanup_java_24_bump branch July 13, 2025 06:34
@paul-dingemans paul-dingemans added this to the 1.7.0 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants