Skip to content

Conversation

mateuszkwiecinski
Copy link
Contributor

@mateuszkwiecinski mateuszkwiecinski commented Jul 2, 2025

Description

For the build-logic project kotlin-dsl plugin (5.2.0) sets its own recommended kotlin version (2.0.21), which is not compatible with latest poko plugin. Our options are:

  1. Bump kotlin-dsl plugin to latest 6.1.2 which hopefully will depend on higher kotlin version - 🔴 doesn't work out of the box, because develocity plugin is not yet compatible
  2. Make the build resolve higher kotlin version for the build-logic project
  3. Migrate away from kotlin-dsl 😛 This types of incompatibilities is one of the reason why I personally prefer not to use kotlin-dsl 😅

This PR implements option 2).

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review July 2, 2025 20:26
@mateuszkwiecinski mateuszkwiecinski changed the title Bump poko-gradle-plugin with a workaround Bump poko-gradle-plugin with a workaround (enforce compatible Kotlin version) Jul 2, 2025
Co-authored-by: Mateusz Kwieciński <36954793+mateuszkwiecinski@users.noreply.github.com>
@@ -1,4 +1,6 @@
plugins {
// TODO: Remove if the build is migrated to Gradle 9
kotlin("jvm") version libs.versions.kotlin.get() apply false // Enforce higher Kotlin version to make `poko-gradle-plugin` compatible.
Copy link
Contributor

@Goooler Goooler Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can bump the project used Gradle to 9.0.0-rc-1 for now. But that should be addressed in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-dingemans paul-dingemans merged commit 2a3c922 into pinterest:master Jul 6, 2025
10 checks passed
@Goooler Goooler mentioned this pull request Jul 6, 2025
8 tasks
@paul-dingemans paul-dingemans added this to the 1.7.0 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants