Skip to content

Java 24 #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 9, 2025
Merged

Java 24 #3049

merged 9 commits into from
Jul 9, 2025

Conversation

paul-dingemans
Copy link
Collaborator

Description

Failing test on Windows with Java24

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

mateuszkwiecinski and others added 9 commits July 5, 2025 23:23
@mateuszkwiecinski
Compile with Java 24
26e12fa
@mateuszkwiecinski
Compile with Java 24
bc5b94e
@mateuszkwiecinski
Smoke test
109ab61
@mateuszkwiecinski
Trying to repro
7a5b110
@paul-dingemans
Merge remote-tracking branch 'github-desktop-mateuszkwiecinski/java_2…
9998814 
…4' into java_24
@paul-dingemans
Suppress warning "A restricted method in java.lang.System has been ca…
7065cc0 
…lled" on Java24+ in SimpleCliTest
@paul-dingemans
Fix lint violation
d556334
@paul-dingemans
Suppress correct message
3f6add0
@paul-dingemans
Prevent test failures on Windows runners in GitHub build
623b25c 
Especially on Windows runners it sometimes happens that the test process is not terminated after completion of the command that is being tested. If the command prints its exit code to the log, that is being used once the test process times out. Commands which are fully handled by Clikt, do not print the exit code to the log, which results in a test failure if the test process expires. So, for Clikt commands the assertions on the exit code are ignored, if the test process has timed out.
@paul-dingemans paul-dingemans mentioned this pull request Jul 9, 2025
Closed
8 tasks
@paul-dingemans paul-dingemans merged commit 920394c into master Jul 9, 2025
23 checks passed
@paul-dingemans paul-dingemans deleted the java_24_copy branch July 9, 2025 19:35
@mateuszkwiecinski mateuszkwiecinski mentioned this pull request Jul 10, 2025
Merged
8 tasks
@paul-dingemans paul-dingemans added this to the 1.7.0 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-dingemans @mateuszkwiecinski