Skip to content

Add web_benchmarks package. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Sep 30, 2020
Merged

Add web_benchmarks package. #1

merged 74 commits into from
Sep 30, 2020

Conversation

pennzht
Copy link
Owner

@pennzht pennzht commented Sep 22, 2020 •
edited
Loading

Working in progress. Do not review yet.

This PR moves Gallery web benchmarks out of flutter/flutter. See flutter/flutter#66351 for more information.

References

web_benchmarks side — #1
gallery side — flutter/gallery#321
flutter side — flutter/flutter#66351

@pennzht
Add recorder.dart.
bea2fb8
@pennzht
Add driver.dart.
5e5cb6a
@pennzht
Remove preset benchmarks.
25c7335
@pennzht
Use correct URI.
1c51217
@pennzht
Add TODO for actual testing.
c38be6b
@pennzht
Remove placeholder.
c16231d
@pennzht
Update placeholder test.
bc58a05
@pennzht
Remove placeholders.
c8d767c
@pennzht
Add meta dependency.
2120238
@pennzht
Use _benchmarks.
1772dbe
@pennzht
Set _benchmarks.
e2c5089
@pennzht
Update driver.dart.
28d9cdb
@pennzht
Update README.md.
b234b7a
@pennzht
Use transitive dependency for meta.
cff9dda
@pennzht
Next step: add an entry point to help testing.
93abf66
@pennzht
Add testing app.
65fb6a9
@pennzht
Update URIs.
5e78b5c
@pennzht
Add TODO: Implement tests.
0216882
@pennzht
Add web_benchmarks.dart.
85f211a
@pennzht
Add server from experimental package web_benchmarks_framework.
e8ddfe3
@pennzht
Add dependencies.
4b83fed
@pennzht
Update pubspec.lock.
c6c3426
@pennzht
Add testing.
d9313e8
@pennzht
Add app for testing.
6600a87
@pennzht
Update paths in web_benchmarks_test.dart.
a868ba9
@pennzht
Remove placeholding main.dart.
7be6519
@pennzht
Add actual test_app.
dc2f81e
@pennzht
Remove test_app_earlier.
ce24e26
@pennzht
Use inner pubspec.yaml from web_benchmarks_example.
28a6878
@pennzht
Use relative path.
7d82add
@pennzht pennzht marked this pull request as ready for review September 29, 2020 19:16
yjbanov
yjbanov approved these changes Sep 30, 2020
View reviewed changes
Copy link

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pennzht pennzht changed the title [WIP] Migrate Gallery benchmarks out of flutter/flutter (web_benchmarks side) Add web_benchmarks package. Sep 30, 2020
@pennzht pennzht merged commit 33aab98 into publish Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pennzht @yjbanov